-
Notifications
You must be signed in to change notification settings - Fork 307
[ViTDet] Remove hardcoded image preprocessing and add ViTDet ImageConverter #2452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @DavidLandup0, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly refactors the image preprocessing for ViTDet models within Keras Hub. The primary goal is to remove the previously hardcoded ImageNet normalization directly embedded in the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request is a good architectural improvement, moving the hardcoded image preprocessing from ViTDetBackbone into a new, dedicated ViTDetImageConverter. The removal of the hardcoded logic in the backbone is done correctly. However, I've found a critical issue in the implementation of the new ViTDetImageConverter where it fails to apply the required ImageNet normalization due to incorrect arguments being passed to its base class. I have also included a suggestion to improve the clarity of the docstring example. Please see the detailed comments below.
| converter = keras_hub.layers.ViTDetImageConverter(image_size=(1024, 1024)) | ||
| converter(np.random.rand(1, 512, 512, 3)) # Resizes and normalizes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The example code is a bit misleading and incomplete:
- It uses
npwithout showing theimport numpy as npstatement. np.random.rand()generates float values in[0, 1). The layer then scales this by1/255, which is likely not the intended demonstration. Usingnp.random.randint(0, 256, ...)would better simulate a typicaluint8image for whichscale=1.0 / 255.0is appropriate.
Please add the import inside the ````pythonblock and userandint` for clarity.
| converter = keras_hub.layers.ViTDetImageConverter(image_size=(1024, 1024)) | |
| converter(np.random.rand(1, 512, 512, 3)) # Resizes and normalizes | |
| converter = keras_hub.layers.ViTDetImageConverter(image_size=(1024, 1024)) | |
| converter(np.random.randint(0, 256, size=(1, 512, 512, 3))) # Resizes and normalizes |
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Description of the change
Currently, ViTDet has a hardcoded imagenet std/mean preprocessing step on the input image, which is not under a flag to turn on/off, and deviates from KHub's conversion convention.
This PR removes the hardcoded step and adds an ImageConverter for ViTDet.
Checklist