Make sure a digital object with no links does not create an empty link

kepper · Dec 5, 2018 · 5ee6b90 · 5ee6b90
1 parent 2980692
commit 5ee6b90
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/app/admin/digital_object.rb b/app/admin/digital_object.rb
@@ -33,13 +33,15 @@ def create
         success.html do
           # If we have a new_object_link_type/id, also create the object link - See the DigitalObjectLink for
           # the fake accessors and the form below for the hidden fields
-          if (params[:digital_object][:new_object_link_type] && params[:digital_object][:new_object_link_id])
+          if (params[:digital_object][:new_object_link_type] && params[:digital_object][:new_object_link_id] &&
+             !params[:digital_object][:new_object_link_type].empty? && !params[:digital_object][:new_object_link_id].empty?
+            )
             dol = DigitalObjectLink.new(
               object_link_type: params[:digital_object][:new_object_link_type],
               object_link_id: params[:digital_object][:new_object_link_id],
               user: resource.user,
-              digital_object_id: resource.id
-            )
+              digital_object_id: resource.id)
+              
             dol.save!
           end
           redirect_to admin_digital_object_path(resource.id)