Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Make responsive community section #7

Merged
merged 6 commits into from
Mar 19, 2024
Merged

Refactor: Make responsive community section #7

merged 6 commits into from
Mar 19, 2024

Conversation

hanzili
Copy link
Contributor

@hanzili hanzili commented Mar 15, 2024

fix #1674

  1. make cards appear on the outer circular lines
image
  1. Bunny image is now visible (small size) in the sm screen size at the top of the cards
image
  1. add hover animation on cards
  2. wasn't able to add parallax animation on the bunny image - the parallax effect requires changing the css properties of the bunny image based on scroll events. It requires additional logic to calculate the image's position dynamically, which easily conflict with the existing css for positioning cards around the bunny.

@nehagup nehagup requested a review from Hermione2408 March 18, 2024 08:03
Hermione2408
Hermione2408 requested changes Mar 18, 2024
View reviewed changes
components/community.tsx Outdated
</div>
type CardData = {
link: string;
svgIcon: any;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please avoid using any it's not a good practice

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree! Since svgIcon is always going to be used as a url, I simply type it as a string.

Hermione2408
Hermione2408 approved these changes Mar 18, 2024
View reviewed changes
Copy link
Member

@Hermione2408 Hermione2408 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @nehagup

nehagup
nehagup approved these changes Mar 19, 2024
View reviewed changes
Copy link
Member

@nehagup nehagup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🫰

@nehagup nehagup merged commit 52cb2ce into keploy:main Mar 19, 2024
1 check passed
Hermione2408 pushed a commit that referenced this pull request Mar 20, 2024
@hanzili @nehagup @Hermione2408
refactor: make responsive community section (#7)
cfdf76c 
* create circular graph

Signed-off-by: hanzili <[email protected]>

* hover animation

Signed-off-by: hanzili <[email protected]>

* fix: svg type

Signed-off-by: hanzili <[email protected]>

---------

Signed-off-by: hanzili <[email protected]>
Co-authored-by: Neha Gupta <[email protected]>
sk-pathan pushed a commit to sk-pathan/keploy-website that referenced this pull request Mar 21, 2024
@hanzili @nehagup @sk-pathan
refactor: make responsive community section (keploy#7)
ead7550 
* create circular graph

Signed-off-by: hanzili <[email protected]>

* hover animation

Signed-off-by: hanzili <[email protected]>

* fix: svg type

Signed-off-by: hanzili <[email protected]>

---------

Signed-off-by: hanzili <[email protected]>
Co-authored-by: Neha Gupta <[email protected]>
Signed-off-by: sk-pathan <[email protected]>
sk0618054 pushed a commit to sk0618054/website that referenced this pull request Mar 22, 2024
@hanzili @nehagup @sk0618054
refactor: make responsive community section (keploy#7)
23d6b51 
* create circular graph

Signed-off-by: hanzili <[email protected]>

* hover animation

Signed-off-by: hanzili <[email protected]>

* fix: svg type

Signed-off-by: hanzili <[email protected]>

---------

Signed-off-by: hanzili <[email protected]>
Co-authored-by: Neha Gupta <[email protected]>
Signed-off-by: SANJEET KUMAR <[email protected]>
sk-pathan pushed a commit to sk-pathan/keploy-website that referenced this pull request Mar 23, 2024
@hanzili @nehagup @sk-pathan
refactor: make responsive community section (keploy#7)
43ebb54 
* create circular graph

Signed-off-by: hanzili <[email protected]>

* hover animation

Signed-off-by: hanzili <[email protected]>

* fix: svg type

Signed-off-by: hanzili <[email protected]>

---------

Signed-off-by: hanzili <[email protected]>
Co-authored-by: Neha Gupta <[email protected]>
Signed-off-by: sk-pathan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hermione2408 Hermione2408 Hermione2408 approved these changes

@nehagup nehagup nehagup approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[refactor]: make responsive community section
3 participants
@hanzili @nehagup @Hermione2408