Conversation
Move them to daemonset file, and remove options that cannot work
There was a problem hiding this comment.
Pull request overview
This PR refactors the DaemonSet volume configuration by moving it from a shared helper template directly into the daemonset.yaml file, and removes volume types (PVC and Secret) that are incompatible with DaemonSet workloads.
Changes:
- Moved volume configuration for DaemonSets from the
kagent.podVolumeshelper template into daemonset.yaml - Removed support for PVC and Secret volume types for DaemonSets (only hostPath and emptyDir are now supported)
- Deleted the now-unused
kagent.podVolumeshelper template from _helpers.tpl
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| templates/daemonset.yaml | Added inline volume configuration supporting hostPath and emptyDir for both data and keypair volumes |
| templates/_helpers.tpl | Removed the kagent.podVolumes helper template and its invocation from kagent.podSpec, as volumes are now configured directly in daemonset.yaml |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move them to daemonset file, and remove options that cannot work