feat: Add core application configuration, CORS middleware, and origin restriction with corresponding tests.#2
Merged
Merged
Conversation
… restriction with corresponding tests.
Owner
Author
|
@cursor review |
Owner
Author
|
@cursor review |
…urate 404 blocking
Owner
Author
|
@cursor review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Adds a global HTTP middleware that blocks requests from non-allowlisted
Originheaders (returning 404), which can break legitimate clients/proxies if origin/host handling is misconfigured. Behavior changes apply to all endpoints and methods, so regression risk is moderate despite being a contained change.Overview
Introduces a strict
Originallowlist middleware that returns a generic 404 (RESOURCE_NOT_FOUND) for requests whoseOriginis not insettings.all_cors_origins, while explicitly allowing same-origin requests.Updates
Settings.all_cors_originsto only appendFRONTEND_HOSTwhen set, and adds async tests covering allowed origins, blocked cross-origin requests, and same-originPOST/PUTbehavior.Written by Cursor Bugbot for commit cb3c208. This will update automatically on new commits. Configure here.