Fix: Sanitize username to prevent single-instance detection failure #12559
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
The single-instance detection feature fails on systems where the environment variable used for the username (USER or USERNAME) contains characters that are invalid in filenames (e.g., /, ).
This prevents the .lock file from being created, which causes the application to allow multiple instances to run simultaneously, even when the option is disabled.
Solution:
This PR resolves the issue by sanitizing the username string before it is used to construct the lock file identifier. It uses a regular expression to find and replace all invalid filename characters with an underscore (_).
This approach is more robust as it protects against invalid characters from any source, ensuring the lock file can always be created.