Implemented GUI CLI arguments for specifying a smartcard #12533
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented GUI CLI arguments for specifying a smartcard in challenge-response mode to use for unlocking a database.
Resolves: #12528
I achieved this by first adding optional smartcard arguments to the entry point of the GUI application before passing it down the call stack all the way to "DatabaseOpenWidget::buildDatabaseKey" and then performing the challenge response procedure both in exactly the same way as the pure CLI.
Usage:
Testing strategy:
I didn't implement test cases for this new feature because the GUI CLI scope was already uncovered by the existing test cases and was therefore unsure how to proceed however I ran the existing tests and received the same results before and after my modifications as well as tested the following cases, if this is a issue I will be happy to ablidge:
Type of change: