Skip to content

Conversation

Spamtributor
Copy link

Implemented GUI CLI arguments for specifying a smartcard in challenge-response mode to use for unlocking a database.

Resolves: #12528

I achieved this by first adding optional smartcard arguments to the entry point of the GUI application before passing it down the call stack all the way to "DatabaseOpenWidget::buildDatabaseKey" and then performing the challenge response procedure both in exactly the same way as the pure CLI.

Usage:

KeePassXC --yubikey 1:12345678 Passwords.kdbx

Testing strategy:

I didn't implement test cases for this new feature because the GUI CLI scope was already uncovered by the existing test cases and was therefore unsure how to proceed however I ran the existing tests and received the same results before and after my modifications as well as tested the following cases, if this is a issue I will be happy to ablidge:

  • Failing to unlock a database with a invalid smartcard argument.
  • Unlocking a database with a valid smartcard argument.
  • Failing to unlock a database with a valid smartcard argument due to it not being connected.
  • Failing to unlock a database with a valid smartcard argument due to failing to press the touch sensor.
  • Failing to unlock a database with a valid smartcard argument due to it not needing one.

Type of change:

  • ✅ New feature (change that adds functionality)

Implemented GUI CLI arguments for specifying a smartcard in challenge-response mode to use for unlocking a database.

Resolves: keepassxreboot#12528

Signed-off-by: Spamtributor <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature request for using a smartcard in challenge-response mode from the GUI CLI

1 participant