Support full DB unlock in single instance mode #12166
Open
+75
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
droidmonkey
requested changes
Jun 8, 2025
droidmonkey
changed the title
mgziminsky
commented
Jun 8, 2025
… instance commands
droidmonkey
requested changes
Jun 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2089
Add support for unlocking databases when running in single instance mode.
I'm not sure what sort of backwards compatibility the IPC socket needs, so I left in the old open only handler, but the main application only calls the new version now. If this isn't necessary, I can just upgrade the original instead of adding a new one.
Testing strategy
Only tested on Linux.
All automated tests pass.
Manual testing with password only, keyfile only, password + keyfile, and multiple databases.
Type of change