This repository has been archived by the owner on Mar 28, 2023. It is now read-only.
Fix migrate contracts CI job #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We pulled a dependency to @keep-network/keep-tecdsa package placed in GitHub Package Registry to package.json. Here we install it as part of migrations script as dependencies are not insatlled from package.json but separately manually instead.
nkuba
force-pushed
the
fix-migrate-contracts
branch
from
1a6db17 to
5d86281
Compare
We set up npm to authenticate with github package registry as a job and persist configuration file to workspace and attach it to jobs which require it. We also use `github-package-registry` context which has configured GITHUB_TOKEN environment variable.
nkuba
force-pushed
the
fix-migrate-contracts
branch
from
20504a1 to
6ee8e65
Compare
keep-tecdsa package was renamed to keep-ecdsa package in @keep-network scope. Here we update the dependency to the new name.
nkuba
force-pushed
the
fix-migrate-contracts
branch
from
6ee8e65 to
8e6db78
Compare
Merged
Shadowfiend
approved these changes
Sep 30, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we update CI to support latest changes from #268 where we import a
@keep-network/keep-ecdsapackage from GitHub Package Registry:GITHUB_TOKENenv variable in.npmrcfile.github-package-registryCircleCI context which hasGITHUB_TOKENenv variable configured..npmrcfile in a workspace..npmrcfile.circleci-migrate-contracts.shscript used bymigrate_contractsjob we install@keep-network/keep-tecdsadependency.@keep-network/keep-tecdsapackage to@keep-network/keep-ecdsa.migrate_contractsstep (which is normally executed onmasterbranch) has been confirmed to work correctly by removing branch filtering. The job was execution successful: https://circleci.com/gh/keep-network/tbtc/6587.