This repository has been archived by the owner on Mar 28, 2023. It is now read-only.
Updates for tBTC 0.1.5 #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're waiting for confirmations for the token to be ready to be minted. tBTC is the application/system, TBTC is the token.
tBTC system no longer use KeepBridge contract and doesn't require passing it's address to DepositFactory. Here we remove the artifact and all references across the code.
We pulled a reference to TBTCConstants contract which will be used in the dapp to get tBTC system parameters.
Deposit factory requires a funder bound to be transfered on new deposit creation. Here we get the required value from TBTCConstants contract and pass it on call to create new deposit.
nkuba
force-pushed
the
updates-recent-tbtc
branch
from
ac58a0c to
dca8ed4
Compare
|
Tested the dApp locally against the system deployed in our private testnet. Deposit funding flow succeded. |
nkuba
requested review from
Shadowfiend,
liamzebedee and
taggartbg
and removed request for
Shadowfiend and
liamzebedee
Updated contracts artifacts to latest versions deployed to private testnet.
Introduced a workaround for a problem with MetaMask version >= 7.1.1 where subscription for emitted events doesn't work correctly. Here we pull past events in a loop until we find one. This commit should be reverted when problem on MetaMask is solved.
Added `return` statement before `resolve` promise function call to exit from the function as soon as we hit this line. Without `return` code in the function may still be executed.
nkuba
force-pushed
the
updates-recent-tbtc
branch
from
dca8ed4 to
bf7bca4
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the dApp code to reflect the latest changes to tBTC and Keep ECDSA projects:
It contains the latest artifacts of tBTC and Keep ECDSA deployed to the private testnet.
It introduces a workaround for a problem with MetaMask where subscriptions for events are not working correctly.