-
Notifications
You must be signed in to change notification settings - Fork 937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor _run_node_async
to use asyncio
#4562
Conversation
_run_node_async
to use asyncio
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great @ravi-kumar-pilla ! Much cleaner than before. I left some minor comments, but otherwise all good 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ravi-kumar-pilla, add it to the release notes :) (Also appreciate the QA notes)
Thank you @ankatiyar ....since this is not a user facing change, I removed it from release notes as suggested here |
Description
Resolves #4289
Development notes
asyncio.run
to call_run_node_async
whenTask.execute
is called withis_async=True
._run_node_async
method to use asyncio_async_dataset_load
and_async_dataset_save
to load and save datasets.asyncio.to_thread
for IO blocking operations (catalog.load and catalog.save)QA notes
kedro run --pipeline=async_test_pipeline
andkedro run --pipeline=async_test_pipeline --async
. Both should yield similar resultstime kedro run --pipeline=async_test_pipeline
andtime kedro run --pipeline=async_test_pipeline --async
. (NOTE: I haven't seen much difference with the datasets available)Developer Certificate of Origin
We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a
Signed-off-by
line in the commit message. See our wiki for guidance.If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.
Checklist
RELEASE.md
file