Start ImageTask in .suspended state #844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kean
commented
Apr 6, 2025
| @@ -152,26 +151,33 @@ public final class ImageTask: Hashable { | |||
| self.isDataTask = isDataTask | |||
| self.pipeline = pipeline | |||
| self.onEvent = onEvent | |||
| // TODO: remove thread hop | |||
| self.task = Task { @ImagePipelineActor in | |||
There was a problem hiding this comment.
ImageTask is created from a nonisolated method (by design), which previously required to spawn a Task to perform it. By delaying the task start until you call one of its async APIs such as response: ImageResponse, we can take advantage of the asynchronous context created by however invokes it. There is no need to spawn one of our own. This eliminates a thread hop.
kean
commented
Apr 6, 2025
| /// The task is currently running. | ||
| case running | ||
| /// The task has received a cancel message. | ||
| case cancelled | ||
| /// The task has completed (without being canceled). | ||
| case completed | ||
| case completed(Result<ImageResponse, Error>) |
There was a problem hiding this comment.
It no longer relies on Task caching of results.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.