btrfs-progs: add ETA display for device replace operations #1047
+0
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam900710
reviewed
Oct 12, 2025
cmds/replace.c
Outdated
| char string1[80]; | ||
| char string2[80]; | ||
| char string3[80]; | ||
| char eta_str[80]; |
There was a problem hiding this comment.
Better to replace the immediate number 80 with a macro.
cmds/replace.c
Outdated
| eta_time = current_time + remaining_time; | ||
| struct tm eta_tm_buf; | ||
| struct tm *eta_tm = localtime_r(&eta_time, &eta_tm_buf); | ||
| strftime(eta_str, sizeof(eta_str), "ETA: %a %b %d %H:%M:%S %Y", eta_tm); |
There was a problem hiding this comment.
Please check the return value, as it is possible to return 0 when the string buffer is not large enough.
cmds/replace.c
Outdated
| if (remaining_time > 0 && total_time > elapsed_time) { | ||
| eta_time = current_time + remaining_time; | ||
| struct tm eta_tm_buf; | ||
| struct tm *eta_tm = localtime_r(&eta_time, &eta_tm_buf); |
There was a problem hiding this comment.
New line between definition and code.
DocMAX
force-pushed
the
devel
branch
2 times, most recently
from
8e6510f to
a522c59
Compare
DocMAX
force-pushed
the
devel
branch
2 times, most recently
from
bbb21bb to
a522c59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add estimated time of arrival (ETA) calculation for device replace operations using progress percentage and elapsed time. The ETA is calculated by determining the total estimated completion time based on current progress ratio and displays the expected completion time in a user-friendly format.