add kcp operator custom metrics #121
Conversation
kcp-ci-bot
added
release-note
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kcp-ci-bot
added
do-not-merge/needs-kind
olamilekan000
requested review from
embik and
mjudeikis
and removed request for
mjudeikis
olamilekan000
force-pushed
the
add-custom-kcp-operator-metrics
branch
from
62caaa4 to
a282340
Compare
|
|
||
| func (mc *MetricsCollector) updateRootShardCounts(ctx context.Context) { | ||
| var rootShards operatorv1alpha1.RootShardList | ||
| if err := mc.client.List(ctx, &rootShards); err != nil { |
There was a problem hiding this comment.
Can we use cache (all below too) here?
There was a problem hiding this comment.
We might not get the actual metric values if they're cached, and besides, I think the Controller-runtime already implements caching by default
| var ( | ||
| RootShardCount = prometheus.NewGaugeVec( | ||
| prometheus.GaugeOpts{ | ||
| Name: "kcp_operator_rootshard_count", |
There was a problem hiding this comment.
Any reason why this is just (I think this is open to discussion @embik )
kcp_operator_object_count{type=rootshard}
Status of these rootshard, shardl frontproxy cache server should be same ?
There was a problem hiding this comment.
This would save us a bit of cardinality:
currently:
4 metrics * 2 dimension = 8
suggested:
1 metrcic * 3 dimensions = 3.
Kubeconfig and certificates would stay separate.
There was a problem hiding this comment.
I am entirely unconvinced that a _count metric is even useful. Users could simple count() other metrics.
There was a problem hiding this comment.
So, this can be removed?
There was a problem hiding this comment.
If we have other metrics with one instance per object, then I'd say yes.
|
|
||
| ConditionStatus = prometheus.NewGaugeVec( | ||
| prometheus.GaugeOpts{ | ||
| Name: "kcp_operator_condition_status", |
There was a problem hiding this comment.
Not sure what this metric is about. Need better docs
There was a problem hiding this comment.
It shows the status of objects installed.
For example, you can have something like this.
kcp_operator_condition_status{condition_type="Available",namespace="default",resource_name="frontproxy-sample",resource_type="frontproxy"} 1
kcp_operator_condition_status{condition_type="Available",namespace="default",resource_name="shard-sample",resource_type="rootshard"} 0
kcp_operator_condition_status{condition_type="RootShard",namespace="default",resource_name="frontproxy-sample",resource_type="frontproxy"} 1
There was a problem hiding this comment.
I wouldbe fine with one metric for the conditions.
There was a problem hiding this comment.
I wouldbe fine with one metric for the conditions.
This is not too clear. Does it mean you're okay with the current implementation?
olamilekan000
force-pushed
the
add-custom-kcp-operator-metrics
branch
6 times, most recently
from
9886ccb to
8c170fc
Compare
Signed-off-by: olalekan odukoya <[email protected]>
olamilekan000
force-pushed
the
add-custom-kcp-operator-metrics
branch
from
8c170fc to
d5ce156
Compare
|
/retest |
4 participants
Summary
What Type of PR Is This?
Related Issue(s)
Fixes 25
Release Notes