Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gimme_taxa.py / ngd mismatched format #215

Open
zreitz opened this issue Aug 27, 2023 · 2 comments
Open

gimme_taxa.py / ngd mismatched format #215

zreitz opened this issue Aug 27, 2023 · 2 comments

Comments

@zreitz
Copy link

zreitz commented Aug 27, 2023

ngd --taxids seems to require gimme_taxa.py have the -j. Not sure if you want to update the documentation or one of the scripts?

$ gimme_taxa.py -o taxids.txt Hyphomicrobiales
$ ngd --dry-run --taxids taxids.txt --assembly-levels complete --refseq-categories representative bacteria
ERROR: No downloads matched your filter. Please check your options.
$ gimme_taxa.py -o taxids.txt Hyphomicrobiales -j
$ ngd --dry-run --taxids taxids.txt --assembly-levels complete --refseq-categories representative bacteria
Considering the following 158 assemblies for download:
<snip>
$ ngd --version
0.3.3
@zreitz zreitz changed the title gimme_taxa.py / ndg mismatched format gimme_taxa.py / ngd mismatched format Aug 27, 2023
@kblin
Copy link
Owner

kblin commented Jul 3, 2024

Interesting, I guess that changed with Nick's rework of gimme_taxa some years ago. It's certainly not a change in ncbi-genome-download. I think it makes most sense to adjust the README.

kblin added a commit that referenced this issue Jul 3, 2024
…th ngd --taxids

This fixes issue #215

Signed-off-by: Kai Blin <[email protected]>
@kblin
Copy link
Owner

kblin commented Jul 3, 2024

Will be shipped with the next release, but is already correct on the GitHub project view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants