Configuring mergeWithDefaults Method to Return Defaults#170
Open
eugenedw wants to merge 3 commits intokatzer:masterfrom
Open
Configuring mergeWithDefaults Method to Return Defaults#170eugenedw wants to merge 3 commits intokatzer:masterfrom
eugenedw wants to merge 3 commits intokatzer:masterfrom
Conversation
this method is returning undefined when attempting to perform printer pick(s). as a result, underlying iOS processes fail as the "pick" method requires options be passed (particularly "bounds").
Issues arose when attempting to perform "pick" requests since the latest version (Typescript) of the plugin doesn't provide a means of sending options.
configuring options merge return defaults on empty
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When calling the printer.pick method, the APPPrinter.m class method fails since options are expected, but none are passed.
(the settings are "null" here).
The decorator associated with the typescript resource for the plugin doesn't allow options to be provided and, subsequently, the option merge returns undefined for the params:
params = this.mergeWithDefaults(params);I've implemented a workaround so that the plugin.js "mergeWithDefaults" returns the defaults when none are passed or an empty object when an empty object is passed in, but this seems like a hack.