-
Notifications
You must be signed in to change notification settings - Fork 57
fix(Controller): Errors are hidden by default #152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Tim-Zhang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @jokemanfire
34ea544 to
9f398c7
Compare
| } | ||
|
|
||
| fn start_default_cgroup(pid: CgroupPid, unit: &str) -> SystemdClient { | ||
| fn start_default_cgroup(pid: CgroupPid, unit: &'_ str) -> SystemdClient<'_> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why add a <'_> here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when I usemake check rustc 1.90 clippy put out this warning.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
error: could not compile cgroups-rs (lib) due to 1 previous error
warning: build failed, waiting for other jobs to finish...
error: hiding a lifetime that's elided elsewhere is confusing
--> src/systemd/dbus/client.rs:251:51
|
251 | fn start_default_cgroup(pid: CgroupPid, unit: &str) -> SystemdClient {
| ^^^^ ------------- the same lifetime is hidden here
| |
| the lifetime is elided here
|
= help: the same lifetime is referred to in inconsistent ways, making the signature confusing
= note: -D mismatched-lifetime-syntaxes implied by -D warnings
= help: to override -D warnings add #[allow(mismatched_lifetime_syntaxes)]
help: use '_ for type paths
|
251 | fn start_default_cgroup(pid: CgroupPid, unit: &str) -> SystemdClient<'_> {
Fixed an error hidden during the creation of cgroup, which resulted in subsequent error propagation Signed-off-by: jokemanfire <[email protected]>
justxuewei
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, thanks!
Bump major(minor actually) version for incompatible changes in kata-containers#154. Changelog: - kata-containers#152 - kata-containers#154 - kata-containers#159 Signed-off-by: Tim Zhang <[email protected]>
I don't think errors should be hidden here, it will cause the error to occur in the subsequent process, and I think this design is incorrect.
you can choose to ignore this error ,but should not hide it in inner.
this will case the panic occur in set_limit,this is unreasonable.