Skip to content

Hacks for usage with stable Rust#30

Closed
dhardy wants to merge 2 commits intomasterfrom
proc-macro-hack
Closed

Hacks for usage with stable Rust#30
dhardy wants to merge 2 commits intomasterfrom
proc-macro-hack

Conversation

@dhardy
Copy link
Collaborator

@dhardy dhardy commented Dec 17, 2019

This puts proc-macro diagnostics behind a feature gate, and uses proc-macro-hack to avoid a requirement on proc_macro_hygiene.

Fixes #25.

I am unsure whether to merge this. As nice as it is to be able to use stable Rust, it hides macro diagnostics by default, uglifies the code-base (especially with make_widget having to be exported from the root of kas), and examples need high macro recursion limits:

// calculator.rs
#![recursion_limit = "1024"]

@dhardy
Copy link
Collaborator Author

dhardy commented Jul 17, 2020

This is now completely obsolete (thanks Rust 1.45 🎉).

@dhardy dhardy closed this Jul 17, 2020
@dhardy dhardy deleted the proc-macro-hack branch July 22, 2020 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nightly feature usage

1 participant