This repository was archived by the owner on May 20, 2024. It is now read-only.
Open
Conversation
NerdyProjects
force-pushed
the
add-influxdb-permissions
branch
from
011ff26 to
06b2ed4
Compare
nicksellen
commented
Jan 30, 2020
Member
Author
nicksellen
left a comment
nicksellen
left a comment
There was a problem hiding this comment.
I didn't through it in a lot of detail, but some comments!
|
|
||
| - name: create influxdb proxy | ||
| include_role: | ||
| name: basic-site |
| site: influxdb-proxy | ||
| site_name: influxdb proxy | ||
| server_name: influxdb.yunity.org | ||
| redirects: [] No newline at end of file |
Member
Author
There was a problem hiding this comment.
How does this work when using server-base for other playbooks which set these variables seperately? If the playbook-defined vars (e.g. playbooks/karrot-world/setup.playbook.yml) correctly overwrite them, maybe add a note here to explain? Otherwise it's a bit confusing what they are kind of reused for a different purpose.
Member
Author
There was a problem hiding this comment.
Another idea would be to just treat influxdb-proxy as a seperate site with it's own folder and playbooks...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re: https://gitlab.com/kanthaus/kanthaus-private/issues/44
The idea is to: