M1/M2 performance fix: use Apple MPS (metal performance shaders) if available#26
Open
sghael wants to merge 2 commits intokarpathy:masterfrom
Open
M1/M2 performance fix: use Apple MPS (metal performance shaders) if available#26sghael wants to merge 2 commits intokarpathy:masterfrom
sghael wants to merge 2 commits intokarpathy:masterfrom
Conversation
Owner
|
Will this code fail for older PyTorch versions? |
Author
|
Good call-out. The first version would trigger an exception on pre1.2 versions of PyTorch. I've modified the code to gracefully degrade with older versions of PyTorch (prior to 1.2). Unfortunately, this adds 2 lines to the code 😄 . PyTorch 2.x on M1 silicon uses PyTorch 1.1 on M1 silicon now reverts to Running Running |
|
Tried the method, but seems like cause this issue #32 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use Apple MPS (metal performance shaders) to move work to M1/M2 GPUs when available. The MPS backend support is part of the PyTorch 1.12 official release.