Avoid unnecessary async-await in WebRequest.PerformAsync

karaoke-dev · Mar 6, 2021 · d625f65 · d625f65
1 parent 7f5f186
commit d625f65
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/osu.Framework.Tests/Visual/Sprites/TestVideo.cs b/osu.Framework.Tests/Visual/Sprites/TestVideo.cs
@@ -3,6 +3,7 @@
 
 using System.IO;
 using System.Threading;
+using System.Threading.Tasks;
 using osu.Framework.Graphics;
 using osu.Framework.Graphics.Video;
 using osu.Framework.IO.Network;
@@ -14,7 +15,7 @@ internal class TestVideo : Video
         private static MemoryStream consumeVideoStream()
         {
             var wr = new WebRequest("https://assets.ppy.sh/media/landing.mp4");
-            wr.PerformAsync();
+            Task.Run(() => wr.PerformAsync());
 
             while (!wr.Completed)
                 Thread.Sleep(100);

diff --git a/osu.Framework/IO/Network/WebRequest.cs b/osu.Framework/IO/Network/WebRequest.cs
@@ -223,7 +223,7 @@ public byte[] GetResponseData()
         /// <summary>
         /// Performs the request asynchronously.
         /// </summary>
-        public async Task PerformAsync() => await PerformAsync(default);
+        public Task PerformAsync() => PerformAsync(default);
 
         /// <summary>
         /// Performs the request asynchronously.