Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement microphone status preview. #154

Merged
merged 6 commits into from
Aug 2, 2020

Conversation

andy840119
Copy link
Member

In order to let player understand microphone is set-up or not.
It's need to make a visual part in game play to let user understand microphone status and how to open microphone.

@andy840119 andy840119 added enhancement New feature or request component New component. labels Aug 1, 2020
@andy840119 andy840119 added this to the 2020.08.15 milestone Aug 1, 2020
@andy840119
Copy link
Member Author

andy840119 commented Aug 1, 2020

TODO :

  1. might get microphone status from KaraokeSessionStatics in KaraokeInputManager
  2. NotePlayfield might be lazy-create until BDL
  3. Add several type in SaitenStatusMode if microphone is not open due to some issue like:
    • NotSaitening: Beatmap is not scoring.
    • Auto play: Auto play.
    • Edit: Editor mode, saiten mark should be hidden(or not loaded) in NotePlayfield

@andy840119
Copy link
Member Author

Need to make a tutorial about how to get microphone permission.
But it should be wait until all tutorial has been written.

@andy840119 andy840119 merged commit f50bae7 into karaoke-dev:master Aug 2, 2020
@andy840119 andy840119 deleted the slave/micrphone-status branch August 2, 2020 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component New component. enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant