Rename the method/variable name to avoid typo error.

karaoke-dev · Mar 3, 2024 · ed7e997 · ed7e997
1 parent 10620b5
commit ed7e997
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 11 deletions.
diff --git a/...sets.Karaoke.Tests/Editor/Generator/Lyrics/Romanisation/Ja/JaRomanisationGeneratorTest.cs b/...sets.Karaoke.Tests/Editor/Generator/Lyrics/Romanisation/Ja/JaRomanisationGeneratorTest.cs
@@ -78,10 +78,10 @@ public void TestGenerateWithUppercase(string text, string[] timeTagStrings, stri
     public void TestConvertToRomanisationGenerateResult(string text, string[] timeTagStrings, string[] romanisationParams, string[] expectedResults)
     {
         var timeTags = TestCaseTagHelper.ParseTimeTags(timeTagStrings);
-        var romanisations = parseRomanisationGenerateResults(romanisationParams);
+        var results = parseRomanisationGenerateResults(romanisationParams);
 
         var expected = RomanisationGenerateResultHelper.ParseRomanisationGenerateResults(timeTags, expectedResults);
-        var actual = JaRomanisationGenerator.Convert(timeTags, romanisations);
+        var actual = JaRomanisationGenerator.Convert(timeTags, results);
 
         AssertEqual(expected, actual);
     }

diff --git a/osu.Game.Rulesets.Karaoke/Edit/Generator/Lyrics/Romanisation/Ja/JaRomanisationGenerator.cs b/osu.Game.Rulesets.Karaoke/Edit/Generator/Lyrics/Romanisation/Ja/JaRomanisationGenerator.cs
@@ -36,13 +36,13 @@ protected override IReadOnlyDictionary<TimeTag, RomanisationGenerateResult> Gene
         var tokenStream = analyzer.GetTokenStream("dummy", new StringReader(text));
 
         // get the processing tags.
-        var processingRomanisations = getProcessingRomanisations(text, tokenStream, Config).ToArray();
+        var parameters = generateParameters(text, tokenStream, Config).ToArray();
 
         // then, trying to mapping them with the time-tags.
-        return Convert(item.TimeTags, processingRomanisations);
+        return Convert(item.TimeTags, parameters);
     }
 
-    private static IEnumerable<RomanisationGeneratorParameter> getProcessingRomanisations(string text, TokenStream tokenStream, JaRomanisationGeneratorConfig config)
+    private static IEnumerable<RomanisationGeneratorParameter> generateParameters(string text, TokenStream tokenStream, JaRomanisationGeneratorConfig config)
     {
         // Reset the stream and convert all result
         tokenStream.Reset();
@@ -85,9 +85,9 @@ private static IEnumerable<RomanisationGeneratorParameter> getProcessingRomanisa
         tokenStream.Dispose();
     }
 
-    internal static IReadOnlyDictionary<TimeTag, RomanisationGenerateResult> Convert(IList<TimeTag> timeTags, IList<RomanisationGeneratorParameter> romanisations)
+    internal static IReadOnlyDictionary<TimeTag, RomanisationGenerateResult> Convert(IList<TimeTag> timeTags, IList<RomanisationGeneratorParameter> parameters)
     {
-        var group = createGroup(timeTags, romanisations);
+        var group = createGroup(timeTags, parameters);
         return group.ToDictionary(k => k.Key, x =>
         {
             bool isFirst = timeTags.IndexOf(x.Key) == 0; // todo: use better to mark the first syllable.
@@ -100,22 +100,22 @@ internal static IReadOnlyDictionary<TimeTag, RomanisationGenerateResult> Convert
             };
         });
 
-        static IReadOnlyDictionary<TimeTag, List<RomanisationGeneratorParameter>> createGroup(IList<TimeTag> timeTags, IList<RomanisationGeneratorParameter> romanisations)
+        static IReadOnlyDictionary<TimeTag, List<RomanisationGeneratorParameter>> createGroup(IList<TimeTag> timeTags, IList<RomanisationGeneratorParameter> parameters)
         {
             var dictionary = timeTags.ToDictionary(x => x, v => new List<RomanisationGeneratorParameter>());
 
             int processedIndex = 0;
 
             foreach (var (timeTag, list) in dictionary)
             {
-                while (processedIndex < romanisations.Count && isTimeTagInRange(timeTags, timeTag, romanisations[processedIndex]))
+                while (processedIndex < parameters.Count && isTimeTagInRange(timeTags, timeTag, parameters[processedIndex]))
                 {
-                    list.Add(romanisations[processedIndex]);
+                    list.Add(parameters[processedIndex]);
                     processedIndex++;
                 }
             }
 
-            if (processedIndex < romanisations.Count - 1)
+            if (processedIndex < parameters.Count - 1)
                 throw new InvalidOperationException("Still have romanisations that haven't process");
 
             return dictionary;