Should have time-tags romaji version in the lyric.

Also, rename from `TimeTagsVersion` into `TimeTagsTimingVersion`.
karaoke-dev · Jul 16, 2023 · 51859f5 · 51859f5
1 parent 1ca70d1
commit 51859f5
Show file tree

Hide file tree

Showing 6 changed files with 37 additions and 23 deletions.
diff --git a/osu.Game.Rulesets.Karaoke.Tests/Objects/LyricTest.cs b/osu.Game.Rulesets.Karaoke.Tests/Objects/LyricTest.cs
@@ -52,7 +52,7 @@ public void TestClone()
         Assert.AreNotSame(clonedLyric.TextBindable, lyric.TextBindable);
         Assert.AreEqual(clonedLyric.Text, lyric.Text);
 
-        Assert.AreNotSame(clonedLyric.TimeTagsVersion, lyric.TimeTagsVersion);
+        Assert.AreNotSame(clonedLyric.TimeTagsTimingVersion, lyric.TimeTagsTimingVersion);
         Assert.AreNotSame(clonedLyric.TimeTagsBindable, lyric.TimeTagsBindable);
         TimeTagAssert.ArePropertyEqual(clonedLyric.TimeTags, lyric.TimeTags);
 
@@ -202,7 +202,7 @@ public void TestReferenceLyricListPropertyChanged()
         TextTagAssert.ArePropertyEqual(referencedLyric.RomajiTags, lyric.RomajiTags);
 
         // and because there's no change inside the tag, so there's version change.
-        Assert.AreEqual(0, lyric.TimeTagsVersion.Value);
+        Assert.AreEqual(0, lyric.TimeTagsTimingVersion.Value);
         Assert.AreEqual(0, lyric.RubyTagsVersion.Value);
         Assert.AreEqual(0, lyric.RomajiTagsVersion.Value);
 
@@ -217,7 +217,7 @@ public void TestReferenceLyricListPropertyChanged()
         TextTagAssert.ArePropertyEqual(referencedLyric.RomajiTags, lyric.RomajiTags);
 
         // and note that because only one property is different, so version should change once.
-        Assert.AreEqual(1, lyric.TimeTagsVersion.Value);
+        Assert.AreEqual(1, lyric.TimeTagsTimingVersion.Value);
         Assert.AreEqual(1, lyric.RubyTagsVersion.Value);
         Assert.AreEqual(1, lyric.RomajiTagsVersion.Value);
     }

diff --git a/osu.Game.Rulesets.Karaoke/Graphics/Sprites/DrawableKaraokeSpriteText.cs b/osu.Game.Rulesets.Karaoke/Graphics/Sprites/DrawableKaraokeSpriteText.cs
@@ -15,7 +15,7 @@ namespace osu.Game.Rulesets.Karaoke.Graphics.Sprites;
     private const int whole_chunk_index = -1;
 
     private readonly IBindable<string> textBindable = new Bindable<string>();
-    private readonly IBindable<int> timeTagsVersion = new Bindable<int>();
+    private readonly IBindable<int> timeTagsTimingVersion = new Bindable<int>();
     private readonly IBindableList<TimeTag> timeTagsBindable = new BindableList<TimeTag>();
     private readonly IBindable<int> rubyTagsVersion = new Bindable<int>();
     private readonly IBindableList<RubyTag> rubyTagsBindable = new BindableList<RubyTag>();
@@ -29,15 +29,15 @@ protected DrawableKaraokeSpriteText(Lyric lyric, int chunkIndex = whole_chunk_in
         this.chunkIndex = chunkIndex;
 
         textBindable.BindValueChanged(_ => UpdateText(), true);
-        timeTagsVersion.BindValueChanged(_ => UpdateTimeTags());
+        timeTagsTimingVersion.BindValueChanged(_ => UpdateTimeTags());
         timeTagsBindable.BindCollectionChanged((_, _) => UpdateTimeTags());
         rubyTagsVersion.BindValueChanged(_ => UpdateRubies());
         rubyTagsBindable.BindCollectionChanged((_, _) => UpdateRubies());
         romajiTagsVersion.BindValueChanged(_ => UpdateRomajies());
         romajiTagsBindable.BindCollectionChanged((_, _) => UpdateRomajies());
 
         textBindable.BindTo(lyric.TextBindable);
-        timeTagsVersion.BindTo(lyric.TimeTagsVersion);
+        timeTagsTimingVersion.BindTo(lyric.TimeTagsTimingVersion);
         timeTagsBindable.BindTo(lyric.TimeTagsBindable);
         rubyTagsVersion.BindTo(lyric.RubyTagsVersion);
         rubyTagsBindable.BindTo(lyric.RubyTagsBindable);

diff --git a/osu.Game.Rulesets.Karaoke/Objects/Lyric_Binding.cs b/osu.Game.Rulesets.Karaoke/Objects/Lyric_Binding.cs
@@ -20,9 +20,14 @@ namespace osu.Game.Rulesets.Karaoke.Objects;
 public partial class Lyric
 {
     [JsonIgnore]
-    public IBindable<int> TimeTagsVersion => timeTagsVersion;
+    public IBindable<int> TimeTagsTimingVersion => timeTagsTimingVersion;
 
-    private readonly Bindable<int> timeTagsVersion = new();
+    private readonly Bindable<int> timeTagsTimingVersion = new();
+
+    [JsonIgnore]
+    public IBindable<int> TimeTagsRomajiVersion => timeTagsRomajiVersion;
+
+    private readonly Bindable<int> timeTagsRomajiVersion = new();
 
     [JsonIgnore]
     public IBindable<int> RubyTagsVersion => rubyTagsVersion;
@@ -54,24 +59,33 @@ private void initInternalBindingEvent()
                     Debug.Assert(args.NewItems != null);
 
                     foreach (var c in args.NewItems.Cast<TimeTag>())
-                        c.TimingChanged += invalidate;
+                    {
+                        c.TimingChanged += timingInvalidate;
+                        c.RomajiChanged += romajiInvalidate;
+                    }
+
                     break;
 
                 case NotifyCollectionChangedAction.Reset:
                 case NotifyCollectionChangedAction.Remove:
                     Debug.Assert(args.OldItems != null);
 
                     foreach (var c in args.OldItems.Cast<TimeTag>())
-                        c.TimingChanged -= invalidate;
+                    {
+                        c.TimingChanged -= timingInvalidate;
+                        c.RomajiChanged -= romajiInvalidate;
+                    }
+
                     break;
             }
 
             updateLyricTime();
 
-            void invalidate() => timeTagsVersion.Value++;
+            void timingInvalidate() => timeTagsTimingVersion.Value++;
+            void romajiInvalidate() => timeTagsRomajiVersion.Value++;
         };
 
-        TimeTagsVersion.ValueChanged += _ =>
+        TimeTagsTimingVersion.ValueChanged += _ =>
         {
             updateLyricTime();
         };
@@ -194,7 +208,7 @@ private void initReferenceLyricEvent()
                 }).ToArray();
             });
 
-            bindValueChange(e, l => l.TimeTagsVersion, (_, config) =>
+            bindValueChange(e, l => l.TimeTagsTimingVersion, (_, config) =>
             {
                 if (config is not SyncLyricConfig syncLyricConfig || !syncLyricConfig.SyncTimeTagProperty)
                     return;

diff --git a/osu.Game.Rulesets.Karaoke/Objects/Note_Binding.cs b/osu.Game.Rulesets.Karaoke/Objects/Note_Binding.cs
@@ -25,16 +25,16 @@ private void initReferenceLyricEvent()
         ReferenceLyricBindable.ValueChanged += e =>
         {
             if (e.OldValue != null)
-                e.OldValue.TimeTagsVersion.ValueChanged -= timeTagVersionChanged;
+                e.OldValue.TimeTagsTimingVersion.ValueChanged -= timeTagsTimingVersionChanged;
 
             if (e.NewValue != null)
-                e.NewValue.TimeTagsVersion.ValueChanged += timeTagVersionChanged;
+                e.NewValue.TimeTagsTimingVersion.ValueChanged += timeTagsTimingVersionChanged;
 
             syncStartTimeAndDurationFromTimeTag();
             syncReferenceLyricSingers();
         };
 
-        void timeTagVersionChanged(ValueChangedEvent<int> e) => syncStartTimeAndDurationFromTimeTag();
+        void timeTagsTimingVersionChanged(ValueChangedEvent<int> e) => syncStartTimeAndDurationFromTimeTag();
     }
 
     private void syncStartTimeAndDurationFromTimeTag()

diff --git a/...esets.Karaoke/Screens/Edit/Beatmaps/Lyrics/Compose/BottomEditor/TimeTagScrollContainer.cs b/...esets.Karaoke/Screens/Edit/Beatmaps/Lyrics/Compose/BottomEditor/TimeTagScrollContainer.cs
@@ -23,7 +23,7 @@ public abstract partial class TimeTagScrollContainer : BindableScrollContainer
 {
     private readonly IBindable<Lyric?> bindableFocusedLyric = new Bindable<Lyric?>();
 
-    private readonly IBindable<int> timeTagsVersion = new Bindable<int>();
+    private readonly IBindable<int> timeTagsTimingVersion = new Bindable<int>();
 
     [Cached]
     private readonly BindableList<TimeTag> timeTagsBindable = new();
@@ -42,19 +42,19 @@ protected TimeTagScrollContainer()
     {
         RelativeSizeAxes = Axes.X;
 
-        timeTagsVersion.BindValueChanged(_ => updateTimeRange());
+        timeTagsTimingVersion.BindValueChanged(_ => updateTimeRange());
         timeTagsBindable.BindCollectionChanged((_, _) => updateTimeRange());
 
         bindableFocusedLyric.BindValueChanged(e =>
         {
-            timeTagsVersion.UnbindBindings();
+            timeTagsTimingVersion.UnbindBindings();
             timeTagsBindable.UnbindBindings();
 
             var lyric = e.NewValue;
             if (lyric == null)
                 return;
 
-            timeTagsVersion.BindTo(lyric.TimeTagsVersion);
+            timeTagsTimingVersion.BindTo(lyric.TimeTagsTimingVersion);
             timeTagsBindable.BindTo(lyric.TimeTagsBindable);
 
             Schedule(() =>

diff --git a/...me.Rulesets.Karaoke/Screens/Edit/Beatmaps/Lyrics/LyricList/Rows/Info/Badge/TimeTagInfo.cs b/...me.Rulesets.Karaoke/Screens/Edit/Beatmaps/Lyrics/LyricList/Rows/Info/Badge/TimeTagInfo.cs
@@ -11,13 +11,13 @@ namespace osu.Game.Rulesets.Karaoke.Screens.Edit.Beatmaps.Lyrics.LyricList.Rows.
 
 public partial class TimeTagInfo : SubInfo
 {
-    private readonly IBindable<int> bindableTimeTagsVersion;
+    private readonly IBindable<int> bindableTimeTagsTimingVersion;
     private readonly IBindableList<TimeTag> bindableTimeTags;
 
     public TimeTagInfo(Lyric lyric)
         : base(lyric)
     {
-        bindableTimeTagsVersion = lyric.TimeTagsVersion.GetBoundCopy();
+        bindableTimeTagsTimingVersion = lyric.TimeTagsTimingVersion.GetBoundCopy();
         bindableTimeTags = lyric.TimeTagsBindable.GetBoundCopy();
     }
 
@@ -26,7 +26,7 @@ private void load(OsuColour colours)
     {
         BadgeColour = colours.Green;
 
-        bindableTimeTagsVersion.BindValueChanged(_ => updateBadgeText());
+        bindableTimeTagsTimingVersion.BindValueChanged(_ => updateBadgeText());
         bindableTimeTags.BindCollectionChanged((_, _) => updateBadgeText());
 
         updateBadgeText();