fix: account for tilePos.x getting out of the level boundary#1043
Open
benhuangbmj wants to merge 2 commits intokaplayjs:masterfrom
Open
fix: account for tilePos.x getting out of the level boundary#1043benhuangbmj wants to merge 2 commits intokaplayjs:masterfrom
benhuangbmj wants to merge 2 commits intokaplayjs:masterfrom
Conversation
Contributor
you sure about that? |
Contributor
Author
What I meant was, suppose the level has m rows and n columns, then its tiles are indexed from 0 to m*n - 1. As long as 0 <= However, without the "0 <= |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please describe what issue(s) this PR fixes.
levelComp.getAtreturns incorrect results whentilePos.xis beyond the scope of the level.Summary
When the
tilePosis beyond the scope of the level, thegetAtmethod should return an empty array. Thetile2Hashfunction already accounts fortilePos.ygetting outside of the level. However, it doesn't work fortilePos.xproperly. I added a simple check in thegetAtmethod without touching any other part of the code to avoid unexpected breaking behavior.