Add tolerance to cache metadata#375
Open
zipdoki wants to merge 3 commits into
Open
Conversation
dosubot
Bot
added
the
size:XS
Contributor
|
Could you add a comment explaining what limit and tolerance mean here? Also, please clarify how many items will be retained. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
tolerancefield to cache metadata, bounding the margin of concurrent delete/update operations absorbed during cache prune (on top oflimit).When absent,
tolerancedefaults tolimit * 2so older metadata deserializes with a concrete value. An explicit value is kept as-is; an explicitnullis rejected.Follows up on #322.
Changes
tolerance: InttoCache, defaulting tolimit * 2, validated as> 0How to Test
./gradlew :core:test :server:testAI Assistance