Drop HBase from spark-conventions (#309 regression)#334
Merged
Conversation
PR #312 removed HBase from SparkConventionsPlugin. PR #309 (`feat/cache-dimension`) carried `2925a4a "Revert ... main into feat/cache-dimension"`, which restored those five lines, and the revert was carried into main when #309 merged. The re-added hbase-shaded-client/mapreduce jars shadow Hadoop's FileSystem on the pipeline test classpath, breaking Spark jobs. Re-removes the five lines.
1 task
dosubot
Bot
added
size:XS
em3s
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Re-removes the HBase implementation dependencies from
SparkConventionsPlugin. PR #312 already removed them; PR #309 (feat/cache-dimension) carried2925a4a "Revert ... main into feat/cache-dimension", which restored those five lines, and the revert was carried into main when #309 merged.hbase-shaded-{client,mapreduce}bundle Hadoop 2.x classes at theorg.apache.hadoop.*namespace (incomplete shading). On the pipeline test classpath they mask the Hadoop 3.3.4 classes Spark expects, causingNoSuchMethodError: FileSystem.openFile.Closes #
Changes
Dependencies.HBase.CLIENTandDependencies.HBase.MAPREDUCEfromSparkConventionsPluginHow to Test
CI on #314, which absorbs this change locally, passed end-to-end.
AI Assistance