Refactor/telemetry types #841
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… use of json tags.
…assandra reconciliation stage (remove an sts restart).
… struct field from method.
Miles-Garnsey
force-pushed
the
refactor/telemetry-types
branch
from
fd68f97 to
0cc0ac2
Compare
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #841 +/- ##
==========================================
- Coverage 56.80% 56.75% -0.06%
==========================================
Files 91 96 +5
Lines 9154 9504 +350
==========================================
+ Hits 5200 5394 +194
- Misses 3487 3629 +142
- Partials 467 481 +14
|
Miles-Garnsey
force-pushed
the
refactor/telemetry-types
branch
from
0cc0ac2 to
50c99af
Compare
|
SonarCloud Quality Gate failed.
|
|
I need to put this on hold pending (what I suspect will be) a bugfix in controller-tools. See my issue here for more details. |
|
@Miles-Garnsey, should we close this PR? |
|
Undoubtedly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Refactors MCAC and Cassandra telemetry agent configurations out of the TelemetrySpec and into CassandraTelemetrySpec. This is necessary because TelemetrySpec is used for Reaper and Stargate and these components do not support those configurations.
Which issue(s) this PR fixes:
Fixes #840
Checklist