Merge japanese-to-english multilingual branch #1860
Conversation
baileyeet
changed the title
|
|
||
| ```shell | ||
| ./zipformer/streaming_decode.py \ | ||
| --epoch 28 \ |
There was a problem hiding this comment.
Since the Reazonspeech is a large dataset, I suggest that you replace --epoch with --iter. See also RESULTS.md from our Gigaspeech recipe. You can find example usages of --iter there.
|
With regards to Setup Python 3.10.15 issue - how do I resolve this issue? I didn't change anything related to Python issue. |
please change icefall/.github/workflows/style_check.yml Line 39 in ab91112 to That is, change It is an issue of GitHub actions and is not related to your PR. |
Looks like this hasn't resolved the issue. |
|
Please use not |
|
@JinZr Can you have a review? |
|
ok! i’ll look into it this weekend
Best Regards
Jin
…On Mon, 20 Jan 2025 at 18:20 Fangjun Kuang ***@***.***> wrote:
@JinZr <https://github.com/JinZr> Can you have a review?
—
Reply to this email directly, view it on GitHub
<#1860 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOON42C3NPJXZY77BY33URL2LTEWBAVCNFSM6AAAAABUW64FCWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMBRHE4TSMZQGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
icefall/utils.py
Outdated
| @@ -644,7 +644,8 @@ def write_error_stats( | |||
| results[i] = (cut_id, ref, hyp) | |||
|
|
|||
| for cut_id, ref, hyp in results: | |||
| ali = kaldialign.align(ref, hyp, ERR, sclite_mode=sclite_mode) | |||
| # ali = kaldialign.align(ref, hyp, ERR, sclite_mode=sclite_mode) | |||
| ali = kaldialign.align(ref, hyp, ERR) | |||
There was a problem hiding this comment.
Could you provide some context on why the ''sclite_mode'' argument was removed?
There was a problem hiding this comment.
please avoid unnecessary modifications to built-in files
There was a problem hiding this comment.
please avoid unnecessary modifications to built-in files, thanks
No description provided.