Skip to content

Ensure that Autopilot can be disabled for real #6738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 4, 2025
Merged

Ensure that Autopilot can be disabled for real #6738

merged 1 commit into from
Dec 4, 2025
+36 −22

Conversation

@twz123
Copy link
Member

@twz123 twz123 commented Nov 25, 2025

Description

The disable component flag only guarded the CRD and RBAC application, but the actual Autopilot components were still started.

Add the new field autopilotDisabled to the worker profiles config map to transport this information over to the workers.

See:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@twz123 twz123 added bug Something isn't working component/autopilot labels Nov 25, 2025
@twz123 twz123 marked this pull request as ready for review November 25, 2025 11:57
@twz123 twz123 requested review from a team as code owners November 25, 2025 11:57
@twz123 twz123 requested review from kke and ncopa November 25, 2025 11:57
@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2025

This pull request has merge conflicts that need to be resolved.

@twz123 twz123 force-pushed the disable-autopilot branch from c6bb260 to ed5e561 Compare December 4, 2025 08:49
@twz123
Ensure that Autopilot can be disabled for real
aaea09d 
The disable component flag only guarded the CRD and RBAC application,
but the actual Autopilot components were still started.

Add the new field autopilotDisabled to the worker profiles config map
to transport this information over to the workers.

See: 9ec69a2 ("Apply Autopilot RBAC only when Autopilot is enabled")
Signed-off-by: Tom Wieczorek <[email protected]>
@twz123 twz123 force-pushed the disable-autopilot branch from ed5e561 to aaea09d Compare December 4, 2025 09:21
@twz123 twz123 merged commit d90766e into k0sproject:main Dec 4, 2025
200 of 201 checks passed
@twz123 twz123 deleted the disable-autopilot branch December 4, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnummelin jnummelin jnummelin approved these changes

@ncopa ncopa Awaiting requested review from ncopa ncopa is a code owner automatically assigned from k0sproject/k0s-maintainers

@kke kke Awaiting requested review from kke kke is a code owner automatically assigned from k0sproject/k0s-maintainers

Assignees

No one assigned

Labels

bug Something isn't working component/autopilot

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@twz123 @jnummelin