Enable "k0s status" on Windows workers #6719
Merged
+147
−80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kke
force-pushed
the
k0s-status-on-win
branch
2 times, most recently
from
063218c to
a0d8253
Compare
Contributor
Author
C:\Users\Administrator> k0s status
Version: v1.34.1+k0s.0-272-gb9f57feaf
Process ID: 4028
Role: worker
Workloads: true
SingleNode: false
Kube-api probing successful: true
Kube-api probing last error: |
kke
force-pushed
the
k0s-status-on-win
branch
3 times, most recently
from
9bee0b9 to
0e285d5
Compare
Contributor
Author
|
Autopilot always uses the default socket path 🤔 ref: #6750 |
kke
force-pushed
the
k0s-status-on-win
branch
2 times, most recently
from
d3b08fd to
1353d86
Compare
kke
changed the title
kke
force-pushed
the
k0s-status-on-win
branch
from
1353d86 to
9242028
Compare
kke
changed the title
kke
force-pushed
the
k0s-status-on-win
branch
from
9242028 to
3f74aaa
Compare
Named pipes are now used for the status component on Windows. Autopilot has been changed to use the constant from the status package instead of defining a new constant. Note that autopilot currently breaks if you don't use the default status socket path, this needs to be fixed elsewhere. Signed-off-by: Kimmo Lehto <[email protected]>
The "k0s status" sub-command was not built into Windows binaries as the status compoennt did not yet run on windows. Signed-off-by: Kimmo Lehto <[email protected]>
kke
force-pushed
the
k0s-status-on-win
branch
from
3f74aaa to
95fa26f
Compare
twz123
reviewed
Dec 2, 2025
Comment on lines
+145
to
+149
| if cobraCmd != nil { | ||
| if val, err := cobraCmd.Flags().GetString("status-socket"); err == nil { | ||
| statusSocketPath = val | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
I think this is not required, as it's done in WithCommand, which is being called later in this method?
Suggested change
| if cobraCmd != nil { | |
| if val, err := cobraCmd.Flags().GetString("status-socket"); err == nil { | |
| statusSocketPath = val | |
| } | |
| } |
Contributor
Author
There was a problem hiding this comment.
Yeah, looks like that, I followed what is done above with data-dir and kubelet-root-dir. I think the withCommand overwrites those too.
Contributor
Author
There was a problem hiding this comment.
Looks like it may be a larger can of worms and it could be better to fix separately as it applies to other flags too.
Signed-off-by: Kimmo Lehto <[email protected]>
Signed-off-by: Kimmo Lehto <[email protected]>
Signed-off-by: Kimmo Lehto <[email protected]>
The client can be built universally, only the dialcontext needs to be different for linux/win. Co-authored-by: Tom Wieczorek <[email protected]> Signed-off-by: Kimmo Lehto <[email protected]>
Move listener creation from Init function to Start as Init is not supposed to create resources that need clean-up. Let httpserver.Shutdown handle closing of the listener. Signed-off-by: Kimmo Lehto <[email protected]>
The run-dir is forced to /run/k0s for root above so there's no need to re-check euid when building the socket path. Signed-off-by: Kimmo Lehto <[email protected]>
Signed-off-by: Kimmo Lehto <[email protected]>
twz123
added
the
backport/release-1.34
Contributor
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Uses pipe based transport on Windows to serve and query the status component.
Fixes #2887
Type of change
How Has This Been Tested?
Checklist