Fix internal/http/TestDownload_CancelDownload #6630
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The test's server handler used to loop on writes. Once the client canceled the download, the next write hit a broken pipe and failed the test intermittently:
The handler now writes once, flushes to let the client see the written data, waits for the request context being done, and asserts that the request context was canceled, hence it will never write more than once.
Fixes test failures like the following:
Type of change
How Has This Been Tested?
Checklist