Code refactoring

k-tamura · Oct 31, 2019 · ef48899 · ef48899
1 parent 0b97576
commit ef48899
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 8 deletions.
diff --git a/src/main/java/org/t246osslab/easybuggy4sb/troubles/ThreadUnsafeController.java b/src/main/java/org/t246osslab/easybuggy4sb/troubles/ThreadUnsafeController.java
@@ -13,8 +13,9 @@
 @Controller
 public class ThreadUnsafeController extends AbstractController {
 
-	private static SimpleDateFormat sdf = new SimpleDateFormat("yyyyMMdd");
-	static {
+	private SimpleDateFormat sdf = new SimpleDateFormat("yyyyMMdd");
+
+	public ThreadUnsafeController() {
 		sdf.setLenient(false);
 	}
 

diff --git a/src/main/java/org/t246osslab/easybuggy4sb/troubles/WeakReferenceController.java b/src/main/java/org/t246osslab/easybuggy4sb/troubles/WeakReferenceController.java
@@ -9,9 +9,6 @@
 import java.util.logging.Logger;
 import java.util.logging.SimpleFormatter;
 
-import javax.servlet.http.HttpServletRequest;
-import javax.servlet.http.HttpServletResponse;
-
 import org.springframework.stereotype.Controller;
 import org.springframework.web.bind.annotation.ModelAttribute;
 import org.springframework.web.bind.annotation.RequestMapping;
@@ -25,7 +22,7 @@
 public class WeakReferenceController extends AbstractController {
 
     @RequestMapping(value = "/weakreference", method = RequestMethod.GET)
-    public ModelAndView doGet(ModelAndView mav, @ModelAttribute("logLevel") String logLevel, HttpServletRequest req, HttpServletResponse res, Locale locale) {
+    public ModelAndView doGet(ModelAndView mav, @ModelAttribute("logLevel") String logLevel, Locale locale) {
 
     	setViewAndCommonObjects(mav, locale, "weakreference");
 
@@ -43,7 +40,7 @@ public ModelAndView doGet(ModelAndView mav, @ModelAttribute("logLevel") String l
 
     @RequestMapping(value = "/weakreference", method = RequestMethod.POST)
 	public String process(@RequestParam(value = "logLevel", required = false) String logLevel,
-			RedirectAttributes redirectAttributes, HttpServletRequest req, HttpServletResponse res, Locale locale) throws IOException {
+			RedirectAttributes redirectAttributes) throws IOException {
 
 		Logger logger = Logger.getLogger(this.getClass().getCanonicalName());
 		logger.setLevel(Level.parse(logLevel));
@@ -53,6 +50,5 @@ public String process(@RequestParam(value = "logLevel", required = false) String
         handler.setFormatter(formatter);
         redirectAttributes.addFlashAttribute("logLevel", logLevel);
         return "redirect:/weakreference";
-
     }
 }