Trivial improvement

k-tamura · Mar 27, 2017 · 0c88f7f · 0c88f7f
1 parent 4c28867
commit 0c88f7f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/src/main/java/org/t246osslab/easybuggy/core/utils/EmailUtils.java b/src/main/java/org/t246osslab/easybuggy/core/utils/EmailUtils.java
@@ -30,6 +30,11 @@ public class EmailUtils {
 
     private static final Logger log = LoggerFactory.getLogger(EmailUtils.class);
 
+    // squid:S1118: Utility classes should not have public constructors
+    private EmailUtils() {
+        throw new IllegalAccessError("Utility class");
+    }
+
     public static boolean isReadyToSendEmail() {
         if (ApplicationUtils.getSmtpHost() == null || "".equals(ApplicationUtils.getSmtpHost())
                 || ApplicationUtils.getSmtpPort() == null || "".equals(ApplicationUtils.getSmtpPort())

diff --git a/src/main/java/org/t246osslab/easybuggy/vulnerabilities/MailHeaderInjectionServlet.java b/src/main/java/org/t246osslab/easybuggy/vulnerabilities/MailHeaderInjectionServlet.java
@@ -65,6 +65,7 @@ protected void doGet(HttpServletRequest req, HttpServletResponse res) throws Ser
                 + MessageUtils.getMsg("label.submit", locale) + "\"/></td>");
         bodyHtml.append("</tr>");
         bodyHtml.append("</table>");
+        bodyHtml.append("<br>");
         bodyHtml.append(MessageUtils.getMsg("msg.note.mail.header.injection", locale));
         if (req.getAttribute("message") != null) {
             bodyHtml.append("<br><br>");