Add Unicode properties of East Asian Width #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds Unicode properties about East Asian Width. http://unicode.org/reports/tr11/ Supports only full name because some aliases are duplicated, such as N. In Unicode 10.0.0, this adds below: - Ambiguous - Fullwidth - Halfwidth - Neutral - Narrow - Wide For reference, Perl's regular expression supports "East_Asian_Width: *" type Unicode property like "General_Category: *". https://perldoc.perl.org/perluniprops.html
Codecov Report
@@ Coverage Diff @@
## master #102 +/- ##
=======================================
Coverage 82.86% 82.86%
=======================================
Files 62 62
Lines 12827 12827
=======================================
Hits 10629 10629
Misses 2198 2198Continue to review full report at Codecov.
|
|
@k-takata How is this? |
|
I object this because width information is not useful in real world. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request adds Unicode properties about East Asian Width. Supports only full name because some aliases are duplicated, such as
N.In Unicode 10.0.0, this adds below:
AmbiguousFullwidthHalfwidthNeutralNarrowWideThis Pull Request doesn't contain update files because those files depend on #101.
For reference, Perl's regular expression supports
East_Asian_Width: *type Unicode property likeGeneral_Category: *.ref. https://bugs.ruby-lang.org/issues/14618