Replaced the use of Tensor.index(m) with Tensor[m]#289
Open
ahmed-shariff wants to merge 4 commits intojwyang:masterfrom
Open
Replaced the use of Tensor.index(m) with Tensor[m]#289ahmed-shariff wants to merge 4 commits intojwyang:masterfrom
ahmed-shariff wants to merge 4 commits intojwyang:masterfrom
Conversation
Contributor
Author
|
Also it would be nice if someone can test this on a system with sufficient memory to check if it works in later version of pytorch and python3.7. My pc only has 2GB of memory, and so far I can squeeze out one step. |
|
It works in pytorch 0.4.1, python 3.6. |
Contributor
Author
|
I should be able to get access to a better pc coming week, will test this on the master branch of pytorch and let you guys know how it goes |
Contributor
Author
|
This works in pytroch '0.5.0a0+f126687' (built from source on pytorch/pytorch@f126687) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The later versions of pytorch don't seem to support the tensor.index function. Hence, I have replaced the
indexfunction with the[]indexing.