-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve error message when a tag is not found and match is set. #77
Improve error message when a tag is not found and match is set. #77
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #77 +/- ##
=======================================
Coverage 97.67% 97.67%
=======================================
Files 17 17
Lines 1246 1249 +3
Branches 211 212 +1
=======================================
+ Hits 1217 1220 +3
Misses 15 15
Partials 14 14 ☔ View full report in Codecov by Sentry. |
292c18f
to
274a78a
Compare
It was not obvious from a few mins of looking how to best update the test data depending on if match is used or not |
a9e9121
to
7e902bd
Compare
02bd4d4
to
225e243
Compare
@jenshnielsen I've taken care of the tests, as well as various improvements to ensure that all mentions of |
Thanks @jwodder that looks like a great improvement and much more useful than my original contribution |
@jenshnielsen This has just been released in versioningit v3.1.0. |
If match is set and you do not have any tags matching this but you do have other tags the error shown is
git describe
could not find a tag` which is slightly confusing since there are tags and running git describe at the command line will return a tag. This just tweaks the error message to include the match argument in such a case.