-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support "onbuild" step when using Hatch #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #53 +/- ##
==========================================
+ Coverage 97.58% 97.67% +0.08%
==========================================
Files 17 17
Lines 1119 1246 +127
Branches 181 211 +30
==========================================
+ Hits 1092 1217 +125
- Misses 14 15 +1
- Partials 13 14 +1 ☔ View full report in Codecov by Sentry. |
decafad
to
ec482e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking change
Introduction of an incompatible API change
builder:hatch
Integration with Hatch build backend
enhancement
New feature or request therefor
method API
Relating to the APIs for creating custom methods
step:onbuild
Relating to the "onbuild" step
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #54.
Blocked by pypa/hatch#1030.
This is a breaking change to the custom methods API, as the
build_dir
argument to "onbuild" methods has been replaced with aFileProvider
ABC.To do:
onbuild.py
[tool.versioningit.onbuild]
is defined when using Hatch[tool.versioningit.onbuild]
is ignored & warned on when using Hatch