Skip to content

Commit

Permalink
remove __REDUX_DEV_UI__ as it's an extension now
Browse files Browse the repository at this point in the history
  • Loading branch information
krystophv committed Feb 23, 2017
1 parent 93ea4c7 commit aa8d04c
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 7 deletions.
5 changes: 1 addition & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -51,11 +51,8 @@ The environment variable `DEBUG_ERROR` (boolean) controls whether or not errors

The environment variable `REDUX_LOG` (boolean) controls whether or not the [redux logger middleware](https://github.com/fcomb/redux-logger/blob/master/README.md) is included. This middleware logs all redux actions in the Chrome developer console, including the (entire) previous and following app state trees. It is primarily useful when working on the UI of the app, and in fact can be quite performance-expensive (especially when uploading a device, due to the fact that every update to the progress bar constitutes an action), so it is not recommended to turn it on while working on device code.

#### `REDUX_DEV_UI`

The environment variable `REDUX_DEV_UI` (boolean) controls whether or not the [redux dev tools UI](https://github.com/gaearon/redux-devtools/blob/master/README.md) is included. The redux dev tools add a UI interface for exploring - and, to a limited extent, manipulating - app actions and state. Even when `REDUX_DEV_UI` is `true`, we have the dev tools hidden by default: the key combination `ctrl + h` will toggle their visibility. The key combination `ctrl + q` will rotate (clockwise) the location at which the dev tools are anchored; the default is for them to be anchored at the bottom of the app. Similarly to the redux logger middleware, the redux dev tools UI is also quite performance expensive and only recommended for use while working on UI code.

`REDUX_LOG` and `REDUX_DEV_UI` are both turned on by default in `config/ui-debug.sh`.
`REDUX_LOG` is turned on by default in `config/ui-debug.sh`.

### Local Development w/o Debug Mode(s)

Expand Down
2 changes: 1 addition & 1 deletion app/store/configureStore.development.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/* global __REDUX_DEV_UI__, __REDUX_LOG__ */
/* global __REDUX_LOG__ */

import { createStore, applyMiddleware, compose } from 'redux';
import thunk from 'redux-thunk';
Expand Down
1 change: 0 additions & 1 deletion webpack.config.development.js
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,6 @@ export default validate(merge(baseConfig, {
'process.env.NODE_ENV': JSON.stringify(process.env.NODE_ENV) || '"development"',
__DEBUG__: JSON.stringify(JSON.parse(process.env.DEBUG_ERROR || 'false')),
__REDUX_LOG__: JSON.stringify(JSON.parse(process.env.REDUX_LOG || 'false')),
__REDUX_DEV_UI__: JSON.stringify(JSON.parse(process.env.REDUX_DEV_UI || 'false')),
__TEST__: false,
'global.GENTLY': false, // http://github.com/visionmedia/superagent/wiki/SuperAgent-for-Webpack for platform-client
})
Expand Down
1 change: 0 additions & 1 deletion webpack.config.production.js
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,6 @@ export default validate(merge(baseConfig, {
'process.env.NODE_ENV': JSON.stringify('production'),
__DEBUG__: JSON.stringify(JSON.parse(process.env.DEBUG_ERROR || 'false')),
__REDUX_LOG__: JSON.stringify(JSON.parse(process.env.REDUX_LOG || 'false')),
__REDUX_DEV_UI__: JSON.stringify(JSON.parse(process.env.REDUX_DEV_UI || 'false')),
__TEST__: false,
'global.GENTLY': false, // http://github.com/visionmedia/superagent/wiki/SuperAgent-for-Webpack for platform-client
}),
Expand Down

0 comments on commit aa8d04c

Please sign in to comment.