Added list of contributors #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

jamiya-begam-k-17 wants to merge 7 commits into jvondermarck:main from jamiya-begam-k-17:main

jamiya-begam-k-17 commented Jan 1, 2026 •

edited

Loading

✅ PR Checklist

Tip

Please check the boxes below to confirm you followed the contribution guidelines:

My PR title follows the format: [Type]: clear description of change
I used the correct type: Feature, Fix, Refactor, Docs, Test, Chore
I reviewed my code and removed unnecessary debug logs or comments.
I tested my changes and verified they work as expected.
I ran the project to confirm it compiles and runs correctly.
I read the Code of Conduct and the Contribution Guidelines.

📝 What does this PR do?

Added a contributors list section to acknowledge and display project contributors.
It has a star badge, currently it uses built-in badge matching the theme near the dino, and when user clicks it - it opens a 'credits' page.
The page contains title as 'credits', subtitle saying "Thank you to all our contributors", and the list of contributors with their name, avatar, no of commits in grid view and a 'back' button finally.
I couldn't add credits button as we don't have enough space.
In the grid box it only fetches the default value of 30 and shows two contributors per row.
Ensured layout and spacing remain consistent with the current menu design.

🔗 Related Issue

Link to the issue this PR addresses (if any)

This PR fixes/closes: [Feature]: Update the Credits Screen with dynamic contributor avatars from GitHub #262

📸 Screenshots / Demos (if applicable)

💬 Extra Notes (Optional)

I planned to add paginations 10 contributers per page with sorting and filtering options.
And when clicking the contributors it opens their profile in gitHub
As it is my first time writing JavaFX & FXGL and THIS clean code I couldn't do it in time.
Thanks for letting me do this issue.
I may add these features in upcoming versions if I have time.
And I am not sure this code is clean or not but I tried my best and I open for suggestions and feedback.
So please drop your feedback and correct my code if I am wrong.

❤️ Thanks again for your contribution to Dinosaur Exploder!
Your efforts help make this project awesome for everyone. 🦖✨

jamiya-begam-k-17 added 2 commits

January 1, 2026 19:07


          Added the gitHub contributors

8487ccf


          Removed unnecessary debugging logs

8e91273

github-project-automation bot added this to Dinosaur Exploder - Project Management

vercel bot commented Jan 1, 2026 •

edited

Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Review	Updated (UTC)
dinosaur-exploder	Ignored	Preview	Jan 8, 2026 0:59am

github-actions bot reviewed

View reviewed changes

Contributor

github-actions bot left a comment

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

💄Spotless - Format

[💄Spotless - Format] _{reported by reviewdog 🐶}

dinosaur-exploder/src/main/java/com/dinosaur/dinosaurexploder/view/CreditsMenu.java

Line 265 in 8e91273

loadAvatarAsync(avatarUrl, avatarView);

[💄Spotless - Format] _{reported by reviewdog 🐶}

dinosaur-exploder/src/main/java/com/dinosaur/dinosaurexploder/view/CreditsMenu.java

Lines 267 to 268 in 8e91273

    
               return avatarView; 
        
           }

[💄Spotless - Format] _{reported by reviewdog 🐶}

dinosaur-exploder/src/main/java/com/dinosaur/dinosaurexploder/view/CreditsMenu.java

Line 270 in 8e91273

private Label createUsernameLabel(String username) {

[💄Spotless - Format] _{reported by reviewdog 🐶}

dinosaur-exploder/src/main/java/com/dinosaur/dinosaurexploder/view/CreditsMenu.java

Lines 273 to 277 in 8e91273

    
           "-fx-font-family: 'Public Pixel';" 
        
                   + "-fx-font-size: 14px;" 
        
                   + "-fx-text-fill: #00FF00;" 
        
                   + "-fx-font-weight: bold;" 
        
                   + "-fx-effect: dropshadow(gaussian, black, 4, 1.0, 0, 0);");

[💄Spotless - Format] _{reported by reviewdog 🐶}

dinosaur-exploder/src/main/java/com/dinosaur/dinosaurexploder/view/CreditsMenu.java

Line 283 in 8e91273

}

[💄Spotless - Format] _{reported by reviewdog 🐶}

dinosaur-exploder/src/main/java/com/dinosaur/dinosaurexploder/view/CreditsMenu.java

Lines 285 to 340 in 8e91273

    
           private Label createContributionsLabel(int contributions) { 
        
               String text = contributions + " " + languageManager.getTranslation("commits"); 
        
               Label label = new Label(text); 
        
               label.setStyle( 
        
                       "-fx-font-family: 'Public Pixel';" 
        
                               + "-fx-font-size: 12px;" 
        
                               + "-fx-text-fill: #FFFF00;" 
        
                               + "-fx-font-weight: bold;" 
        
                               + "-fx-effect: dropshadow(gaussian, black, 3, 1.0, 0, 0);"); 
        
               return label; 
        
           } 
        
           private void setupHoverEffect(VBox box) { 
        
               box.setOnMouseEntered( 
        
                       e -> { 
        
                           box.setStyle( 
        
                       "-fx-background-color: rgba(0, 80, 0, 0.98);" 
        
                       + "-fx-background-radius: 10;" 
        
                       + "-fx-border-color: rgba(0, 255, 0, 1);" 
        
                       + "-fx-border-width: 3;" 
        
                       + "-fx-border-radius: 10;" 
        
                       + "-fx-effect: dropshadow(gaussian, rgba(0, 255, 0, 0.9), 15, 0.8, 0, 0);"); 
        
                           box.setCursor(javafx.scene.Cursor.HAND); 
        
                       }); 
        
               box.setOnMouseExited( 
        
                       e -> box.setStyle( 
        
                               "-fx-background-color: rgba(0, 0, 0, 0.8);" 
        
                                       + "-fx-background-radius: 10;" 
        
                                       + "-fx-border-color: rgba(0, 220, 0, 0.5);" 
        
                                       + "-fx-border-width: 1;" 
        
                                       + "-fx-border-radius: 10;")); 
        
           } 
        
           private void loadAvatarAsync(String avatarUrl, ImageView avatarView) { 
        
               CompletableFuture.supplyAsync( 
        
                       () -> { 
        
                           try { 
        
                               return new Image(avatarUrl, AVATAR_SIZE, AVATAR_SIZE, true, true, true); 
        
                           } catch (Exception e) { 
        
                               return createPlaceholderAvatar(); 
        
                           } 
        
                       }) 
        
                       .thenAccept(image -> Platform.runLater(() -> avatarView.setImage(image))); 
        
           } 
        
           private Image createPlaceholderAvatar() { 
        
               try { 
        
                   InputStream stream = getClass().getResourceAsStream(GameConstants.GAME_LOGO_DINOSAUR); 
        
                   if (stream != null) { 
        
                       return new Image(stream, AVATAR_SIZE, AVATAR_SIZE, true, true); 
        
                   } 
        
               } catch (Exception e) { 
        
                   System.err.println("Error loading placeholder: " + e.getMessage()); 
        
               } 
        
               return null;

[💄Spotless - Format] _{reported by reviewdog 🐶}

dinosaur-exploder/src/main/java/com/dinosaur/dinosaurexploder/view/CreditsMenu.java

Line 342 in 8e91273

}

[💄Spotless - Format] _{reported by reviewdog 🐶}

dinosaur-exploder/src/main/java/com/dinosaur/dinosaurexploder/view/DinosaurMenu.java

Line 19 in 8e91273

import javafx.animation.TranslateTransition;

[💄Spotless - Format] _{reported by reviewdog 🐶}

dinosaur-exploder/src/main/java/com/dinosaur/dinosaurexploder/view/DinosaurMenu.java

Line 21 in 8e91273

import javafx.geometry.Insets;

[💄Spotless - Format] _{reported by reviewdog 🐶}

dinosaur-exploder/src/main/java/com/dinosaur/dinosaurexploder/view/DinosaurMenu.java

Lines 34 to 35 in 8e91273

    
           import javafx.scene.text.Text; 
        
           import javafx.scene.effect.DropShadow;

[💄Spotless - Format] _{reported by reviewdog 🐶}

dinosaur-exploder/src/main/java/com/dinosaur/dinosaurexploder/view/DinosaurMenu.java

Line 38 in 8e91273

import javafx.util.Duration;

[💄Spotless - Format] _{reported by reviewdog 🐶}

dinosaur-exploder/src/main/java/com/dinosaur/dinosaurexploder/view/DinosaurMenu.java

Line 50 in 8e91273

[💄Spotless - Format] _{reported by reviewdog 🐶}

dinosaur-exploder/src/main/java/com/dinosaur/dinosaurexploder/view/DinosaurMenu.java

Line 99 in 8e91273

    
           backgroundView, titlePane, dinoImage, creditsBadge, muteIcon, languageBox, volumeSlider, volumeText);

[💄Spotless - Format] _{reported by reviewdog 🐶}

dinosaur-exploder/src/main/java/com/dinosaur/dinosaurexploder/view/DinosaurMenu.java

Lines 180 to 182 in 8e91273

    
           badge.setOnMouseClicked(event -> { 
        
             FXGL.getSceneService().pushSubScene(new CreditsMenu()); 
        
           });

[💄Spotless - Format] _{reported by reviewdog 🐶}

dinosaur-exploder/src/main/java/com/dinosaur/dinosaurexploder/view/DinosaurMenu.java

Lines 185 to 189 in 8e91273

    
           badge.setOnMouseEntered(event -> { 
        
             badge.setScaleX(1.2); 
        
             badge.setScaleY(1.2); 
        
             badge.setCursor(javafx.scene.Cursor.HAND); 
        
           });

[💄Spotless - Format] _{reported by reviewdog 🐶}

dinosaur-exploder/src/main/java/com/dinosaur/dinosaurexploder/view/DinosaurMenu.java

Lines 191 to 194 in 8e91273

    
           badge.setOnMouseExited(event -> { 
        
             badge.setScaleX(1.0); 
        
             badge.setScaleY(1.0); 
        
           });

[💄Spotless - Format] _{reported by reviewdog 🐶}

dinosaur-exploder/src/main/java/com/dinosaur/dinosaurexploder/view/DinosaurMenu.java

Line 353 in 8e91273

    
           background, title, startButton, quitButton, dino, creditsBadge, mute, volumeText, volume, language);;

github-actions bot reviewed

View reviewed changes

Contributor

github-actions bot left a comment

👋 Hello @jamiya-begam-k-17, thank you for submitting in Dinosaur Exploder 🦖 PR! To allow your work to be integrated as seamlessly as possible, we advise you to:

✅ Verify your PR is up-to-date with the repository /dinosaur-exploder main branch. If your PR is behind you can update your code by clicking the 'Update branch' button or by running git pull and git merge master locally.
✅ Verify all Dinosaur Exploder Continuous Integration (CI) checks are passing.
✅ Verify that you have well fill out the different checkboxes in the PR template.
⚠️ Check that your code is clean: no code redundancy, variable and method names are correct, your code is understandable to everyone, and so on.
💡 Reduce changes to the absolute minimum required for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." — Bruce Lee

Contributor

github-actions bot commented Jan 1, 2026 •

edited

Loading

✅ Code Formatting Check Passed!

Great job! 🎉 Your code follows the Google Java Style Guide.

🤖 The DinoBot Team 🦖

Contributor

github-actions bot commented Jan 1, 2026 •

edited

Loading

Build preview 🚀

Thanks for your contribution to this open-source project! ❤️

A new build has been generated for this pull request:

🎮 Game Artifacts: 🐧 Linux / 🍎 macOS / 🪟 Windows
🧪 Workflow Run: View Logs
🔖 Commit: a3a68d18256f1d6716f3773bf9e374defb970bae

Tip

This JAR lets you test the latest version of the game from this PR.

⏳ Note: Artifacts auto-expire after ~90 days.

Happy testing & enjoy the game! 🎮

The DinoBot Team 🦖


          style: apply Spotless

9cd6dd3

Owner

jvondermarck commented Jan 1, 2026

That's so insane from what I see on your screenshot. Unfortunately I am on holidays so looking from my phone. I will review it mid january ' But I can say good work, I like it !

Please just fix the Sonarqube issues : https://sonarcloud.io/project/issues?issueStatuses=OPEN%2CCONFIRMED&pullRequest=289&types=BUG&severities=BLOCKER%2CCRITICAL%2CMAJOR%2CMINOR&inNewCodePeriod=true&sinceLeakPeriod=true&id=jvondermarck_dinosaur-exploder

jvondermarck added the status: in-review label

Author

jamiya-begam-k-17 commented Jan 4, 2026 •

edited

Loading

That's so insane from what I see on your screenshot. Unfortunately I am on holidays so looking from my phone. I will review it mid january ' But I can say good work, I like it !

Please just fix the Sonarqube issues : https://sonarcloud.io/project/issues?issueStatuses=OPEN%2CCONFIRMED&pullRequest=289&types=BUG&severities=BLOCKER%2CCRITICAL%2CMAJOR%2CMINOR&inNewCodePeriod=true&sinceLeakPeriod=true&id=jvondermarck_dinosaur-exploder

Hello,
I looked into the SonarQube issues related to the scrollbar CSS.
It seems these warnings come from JavaFX-specific pseudo-classes like :vertical. They are required for JavaFX styling and work correctly at runtime, but SonarQube’s CSS rules don’t recognize them since JavaFX CSS is a bit different from standard web CSS.
I tried alternative selectors to satisfy SonarQube and I also tried programmatic node lookup but both failed for the green scroll bar that causes JavaFX to fall back to the default scrollbar styling which is white.

So would you be okay with excluding JavaFX CSS files from SonarQube analysis or ok with default white scroll bar or do you prefer another approach here? Happy to follow your recommendation.

jvondermarck added 4 commits

January 8, 2026 13:25


          Merge branch 'main' into fork/jamiya-begam-k-17/main

07322fb

# Conflicts:
#	src/main/resources/assets/translation/english.json
#	src/main/resources/assets/translation/french.json
#	src/main/resources/assets/translation/german.json
#	src/main/resources/assets/translation/greek.json
#	src/main/resources/assets/translation/japanese.json
#	src/main/resources/assets/translation/portuguese.json
#	src/main/resources/assets/translation/russian.json
#	src/main/resources/assets/translation/spanish.json


          feat: enhance CreditsMenu with loading and error handling; add Bulgar…

cfa3194

…ian translations


          fix: clean up formatting in CreditsMenu and improve readability

885dac8


          fix: update sonar exclusions to correctly reference resource styles

a3a68d1

sonarqubecloud bot commented Jan 8, 2026

Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

jvondermarck requested changes

View reviewed changes

Owner

jvondermarck left a comment •

edited

Loading

Hey, I excluded the css files to be executed by Sonar !

I also updated the code to remove the grid if there is the loading or the error in the credits. So it avoids taking empty spaces so now there isn't anymore the big empty space between the subtitle and the grid if there is no loading and no error message.

Now there are 5 sonar issues to fix, I guess you can easily solve them, please tell me if you need help !! @jamiya-begam-k-17 -> https://sonarcloud.io/project/issues?id=jvondermarck_dinosaur-exploder&pullRequest=289&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true

github-project-automation bot moved this to In review in Dinosaur Exploder - Project Management

jvondermarck added status: pending-request-changes and removed status: in-review labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: pending-request-changes