Feat(rnpsw): Add Demo Project #222
Conversation
There was a problem hiding this comment.
@just1and0 this PR adds the demo project as described. Please review when you get a chance 🙏
|
Thank a lot @Jokotoye18 for working on this PR! I see how helpful this will be for the community. I'll review and revert. |
demo/README.md
Outdated
| ## 🤝 Contributing | ||
|
|
||
| Feel free to contribute to improve the demo: | ||
|
|
||
| 1. Fork the repository | ||
| 2. Create a feature branch | ||
| 3. Make your changes | ||
| 4. Submit a pull request | ||
|
|
There was a problem hiding this comment.
@Jokotoye18 we have a contribution guideline, you can reference that here rather that listing a new one.
See contribution.md
| - Enter a test email and amount | ||
| - Experience the complete payment flow | ||
|
|
||
| ### 📱 Demo Screenshots |
There was a problem hiding this comment.
Can we take out this header if we aren't adding the screenshot
There was a problem hiding this comment.
I am working on adding a video here. Thanks for re viewing
There was a problem hiding this comment.
That's fine, but if it's not going in this PR, might be best to just take it out ?
There was a problem hiding this comment.
Yeah, let’s take out the header @Jokotoye18
|
[nit] - @Jokotoye18 Could we rename the |
| value: 'OID1234' | ||
| } | ||
| ] | ||
| value: 'OID1234', |
There was a problem hiding this comment.
[low] - @Jokotoye18 let's try to keep linter/prettier-only changes to a minimum so we can focus on the core updates.
| @@ -115,89 +113,119 @@ const Checkout = () => { | |||
|
|
|||
| --- | |||
|
|
|||
| ## 🎮 Demo Project | |||
There was a problem hiding this comment.
[nit] - Demo Example Project
| | `onSuccess` | `(res) => void` | ✅ | Called on successful payment | | ||
| | `onCancel` | `() => void` | ✅ | Called on cancellation | | ||
| | `onLoad` | `(res) => void` | — | Triggered when transaction view loads | | ||
| | `onError` | `(err) => void` | — | Triggered on WebView or script error | |
There was a problem hiding this comment.
[low] - @Jokotoye18, just a heads up, the linter diffs are making it tough to follow the actual changes in this PR. Could you please take another look and try to reduce those where possible?
It'll make reviewing a lot smoother. Thanks 💪🏼
|
Asides the tiny recommended changes, PR LGTM ✅ Approving for now, trusting you'll make the necessary adjustments. |
Description
This pull request adds a demo project showcasing how to integrate and use the
react-native-paystack-webviewpackage.The demo provides a working example for developers to quickly understand how to implement the library in their React Native apps.
Key features:
Issue URL
N/A – This is a new feature contribution and not tied to any existing issue.
Before and After
react-native-paystack-webview. Includes basic payment flow and UI.🎥 Watch the demo video on Imgur