fixing joinMode bug

just-do-halee · Apr 9, 2022 · a8419ef · a8419ef
1 parent 6336291
commit a8419ef
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 6 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,12 @@
+## 0.1.4 (April 10, 2022)
+
+### Release 0.1.4
+
+- Fixed:
+  - joinMode: preserved key bug.
+
+---
+
 ## 0.1.2 (April 10, 2022)
 
 ### Release 0.1.2

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "modern-v",
-  "version": "0.1.3",
+  "version": "0.1.4",
   "description": "Most easy way to get and set the mode in any situation.",
   "main": "dist/cjs/index.js",
   "module": "dist/esm/index.js",

diff --git a/src/functions/joinMode.ts b/src/functions/joinMode.ts
@@ -29,13 +29,17 @@ function joinMode<
   let mergedObj: ObjectOnly<string> = { __MODE__: mode };
 
   for (const key in obj) {
-    if (isPreservedKey(key)) continue;
-
+
     let value = obj[key] === '' ? key : obj[key];
 
-    mergedObj[key] = prefix
-      ? `${mode}${delimiter}${value}`
-      : `${value}${delimiter}${mode}`;
+    if (isPreservedKey(key)) {
+      mergedObj[key] = value;
+    } else {
+      mergedObj[key] = prefix
+        ? `${mode}${delimiter}${value}`
+        : `${value}${delimiter}${mode}`;
+    }
+
   }
 
   return mergedObj as JoinedObject<M, O, Prefix> & { __MODE__: M };