Report more error responses #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Best reviewed commit-by-commit. |
neongreen
force-pushed
the
neongreen/94-error-responses
branch
2 times, most recently
from
7ec275a to
a247e6d
Compare
neongreen
commented
Nov 8, 2019
| @@ -38,6 +38,7 @@ | |||
| - ignore: { name: 'Use const' } | |||
| - ignore: { name: 'Move brackets to avoid $' } | |||
| - ignore: { name: 'Use ?~' } | |||
| - ignore: { name: 'Eta reduce' } | |||
There was a problem hiding this comment.
Ignoring this one because it encourages losing names (cancelCall = Grpc.serverCallCancel serverCall Grpc.StatusUnknown instead of cancelCall err = Grpc.serverCallCancel serverCall Grpc.StatusUnknown err).
There was a problem hiding this comment.
Does this apply project-wide? If so, I'd argue this warning is good to have in general. Is it possible to ignore a warning on a code line/site basis?
|
@neongreen, can you please rebase on top of the latest |
mdimjasevic
approved these changes
Nov 8, 2019
neongreen
force-pushed
the
neongreen/94-error-responses
branch
from
5dca6c1 to
1a0bfc0
Compare
|
Oops, forgot to address the comment about |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #94.