Add date column type in table and total row#1367
Open
vinitkhandal717 wants to merge 3 commits intodevfrom
Open
Add date column type in table and total row#1367vinitkhandal717 wants to merge 3 commits intodevfrom
vinitkhandal717 wants to merge 3 commits intodevfrom
Conversation
commit: |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the Blend data table to better support date-based columns and filtering, adds visible row-count text to pagination, and makes the shared DateRangePicker popover placement configurable.
Changes:
- Added configurable popover positioning to
DateRangePicker. - Added date-range filter UI/logic for
DataTabledate columns, including mobile and desktop filter flows. - Added visible row-count display to table pagination/footer and updated the demo to showcase a date column.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
packages/blend/lib/components/DateRangePicker/types.ts |
Adds public popoverConfig typing for date picker placement. |
packages/blend/lib/components/DateRangePicker/DateRangePicker.tsx |
Wires popover placement props into the picker popover. |
packages/blend/lib/components/DataTable/utils.ts |
Extends column filtering logic with date range handling and updated date comparisons. |
packages/blend/lib/components/DataTable/TableHeader/MobileFilterDrawer.tsx |
Adds mobile date-range filter UI inside the filter drawer. |
packages/blend/lib/components/DataTable/TableHeader/index.tsx |
Updates header filter state extraction to support string-backed values. |
packages/blend/lib/components/DataTable/TableHeader/handlers.ts |
Broadens filter state types to include string values. |
packages/blend/lib/components/DataTable/TableHeader/FilterComponents.tsx |
Adds desktop date filter UI and integrates it into the header menu flow. |
packages/blend/lib/components/DataTable/TableFooter/types.ts |
Adds visibleRows footer prop for pagination display. |
packages/blend/lib/components/DataTable/TableFooter/index.tsx |
Passes visible row counts into pagination. |
packages/blend/lib/components/DataTable/TableCell/index.tsx |
Expands DATE cell handling to accept primitive date values. |
packages/blend/lib/components/DataTable/DataTablePagination.tsx |
Renders the new visible-range text in pagination. |
packages/blend/lib/components/DataTable/DataTable.tsx |
Supplies current visible row counts to the footer. |
apps/site/src/demos/dataTableDemo.tsx |
Updates the demo dataset/columns to showcase a date column and related formatting. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
add row count and add support for date column n along with it's filter
Issue Ticket
Closes #
Screen.Recording.2026-04-21.at.1.55.54.PM.mov