Skip to content

Add date column type in table and total row#1367

Open
vinitkhandal717 wants to merge 3 commits intodevfrom
feat/add-date-column-type-in-table
Open

Add date column type in table and total row#1367
vinitkhandal717 wants to merge 3 commits intodevfrom
feat/add-date-column-type-in-table

Conversation

@vinitkhandal717
Copy link
Copy Markdown
Collaborator

@vinitkhandal717 vinitkhandal717 commented Apr 22, 2026

Summary

add row count and add support for date column n along with it's filter

Issue Ticket

Closes #

Screen.Recording.2026-04-21.at.1.55.54.PM.mov

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Apr 22, 2026

Open in StackBlitz

npm i https://pkg.pr.new/@juspay/blend-design-system@1367

commit: 7406274

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the Blend data table to better support date-based columns and filtering, adds visible row-count text to pagination, and makes the shared DateRangePicker popover placement configurable.

Changes:

  • Added configurable popover positioning to DateRangePicker.
  • Added date-range filter UI/logic for DataTable date columns, including mobile and desktop filter flows.
  • Added visible row-count display to table pagination/footer and updated the demo to showcase a date column.

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
packages/blend/lib/components/DateRangePicker/types.ts Adds public popoverConfig typing for date picker placement.
packages/blend/lib/components/DateRangePicker/DateRangePicker.tsx Wires popover placement props into the picker popover.
packages/blend/lib/components/DataTable/utils.ts Extends column filtering logic with date range handling and updated date comparisons.
packages/blend/lib/components/DataTable/TableHeader/MobileFilterDrawer.tsx Adds mobile date-range filter UI inside the filter drawer.
packages/blend/lib/components/DataTable/TableHeader/index.tsx Updates header filter state extraction to support string-backed values.
packages/blend/lib/components/DataTable/TableHeader/handlers.ts Broadens filter state types to include string values.
packages/blend/lib/components/DataTable/TableHeader/FilterComponents.tsx Adds desktop date filter UI and integrates it into the header menu flow.
packages/blend/lib/components/DataTable/TableFooter/types.ts Adds visibleRows footer prop for pagination display.
packages/blend/lib/components/DataTable/TableFooter/index.tsx Passes visible row counts into pagination.
packages/blend/lib/components/DataTable/TableCell/index.tsx Expands DATE cell handling to accept primitive date values.
packages/blend/lib/components/DataTable/DataTablePagination.tsx Renders the new visible-range text in pagination.
packages/blend/lib/components/DataTable/DataTable.tsx Supplies current visible row counts to the footer.
apps/site/src/demos/dataTableDemo.tsx Updates the demo dataset/columns to showcase a date column and related formatting.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/blend/lib/components/DataTable/TableHeader/index.tsx
Comment thread packages/blend/lib/components/DataTable/TableHeader/FilterComponents.tsx Outdated
Comment thread packages/blend/lib/components/DataTable/TableHeader/MobileFilterDrawer.tsx Outdated
Comment thread packages/blend/lib/components/DataTable/utils.ts Outdated
Comment thread packages/blend/lib/components/DataTable/utils.ts Outdated
Comment thread apps/site/src/demos/dataTableDemo.tsx Outdated
Comment thread packages/blend/lib/components/DataTable/TableCell/index.tsx
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 6 comments.

Comment thread packages/blend/lib/components/DataTable/utils.ts Outdated
Comment thread packages/blend/lib/components/DataTable/TableHeader/FilterComponents.tsx Outdated
Comment thread packages/blend/lib/components/DataTable/TableHeader/MobileFilterDrawer.tsx Outdated
Comment thread packages/blend/lib/components/DataTable/TableHeader/index.tsx
Comment thread packages/blend/lib/components/DataTable/TableCell/index.tsx
Comment thread apps/site/src/demos/dataTableDemo.tsx Outdated
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 6 comments.

Comment thread packages/blend/lib/components/DataTable/utils.ts Outdated
Comment thread packages/blend/lib/components/DataTable/utils.ts Outdated
Comment thread packages/blend/lib/components/DataTable/TableHeader/FilterComponents.tsx Outdated
Comment thread apps/site/src/demos/dataTableDemo.tsx Outdated
Comment thread apps/site/src/demos/dataTableDemo.tsx Outdated
Comment thread apps/site/src/demos/dataTableDemo.tsx Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants