feat:Move New Resources to Important#60
Open
yuvrajjsingh0 wants to merge 1 commit into
Open
Conversation
yuvrajjsingh0
force-pushed
the
move-new-resources-to-important
branch
2 times, most recently
from
d20ca61 to
45c0adf
Compare
Yaswanth0606
requested changes
Jul 15, 2025
| HPJPResource *newResource = newResources[resourceKey]; | ||
| HPJPResource *localResource = localResources[resourceKey]; | ||
|
|
||
| if (!localResource || ![newResource.url.absoluteString isEqualToString:localResource.url.absoluteString]) { |
Contributor
There was a problem hiding this comment.
Can you match filepath also here?
Contributor
Author
There was a problem hiding this comment.
But the key of both the resources would be same if they are same right? And key itself is filepath
| HPJPResource *localResource = localResources[resourceKey]; | ||
|
|
||
| if (!localResource || ![newResource.url.absoluteString isEqualToString:localResource.url.absoluteString]) { | ||
| [resourcesToMoveToImportant addObject:newResource]; |
Contributor
There was a problem hiding this comment.
This resource will always go to package in all the subsequent runs. We should decide if a resource is new after checking for that resource in package also.
Contributor
There was a problem hiding this comment.
Same with android as well.
Contributor
Author
There was a problem hiding this comment.
Done, added a check to see if we have it in pkg important as well before moving
yuvrajjsingh0
force-pushed
the
move-new-resources-to-important
branch
2 times, most recently
from
036c4c2 to
ef205c9
Compare
Yash02Rajput
force-pushed
the
move-new-resources-to-important
branch
2 times, most recently
from
867c578 to
bf55156
Compare
Yash02Rajput
force-pushed
the
move-new-resources-to-important
branch
from
be8febc to
aed17fe
Compare
| AJPApplicationPackage *transformedPackage = [[AJPApplicationPackage alloc] init]; | ||
| transformedPackage.version = downloadedManifest.package.version; | ||
| transformedPackage.name = downloadedManifest.package.name; | ||
| transformedPackage.important = [downloadedManifest.package.important mutableCopy]; |
Contributor
There was a problem hiding this comment.
@yuvrajjsingh0 Can you set index & properties as well in transformedPackage?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.