Skip to content

Remove federation related docs to split using and operating a bhub docs #1160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 19, 2020

Conversation

choldgraf
Copy link
Member

This is a general docs improvement that does a bit of restructuring and tidying. It also complements jupyterhub/mybinder.org-user-guide#213 as I moved over some content to these docs from there.

cc @consideRatio in case he wants to take a look at these too ;-)

Co-authored-by: Erik Sundell <[email protected]>
@choldgraf
Copy link
Member Author

thanks - both applied! I also turned on readthedocs preview builds and if that works, will remove the circleci build (since it's just for docs preview)

Copy link
Member

@consideRatio consideRatio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the requirements.txt details that I wish no-one need to experience debugging more than me and I think @sgibson91 have already ended up doing, this LGTM! Thank you for your excellent work to make the documentation so great @choldgraf !

@betatim betatim changed the title 📚 DOCS: documentation update Remove federation related docs to split using and operating a bhub docs Oct 5, 2020
@betatim
Copy link
Member

betatim commented Oct 5, 2020

WDYT of the new title? I couldn't resist trying to find an alternative to the very generic one

The federation related things that have been removed, did they get added back somewhere else in a different repo/page?
edit: somehow the link to jupyterhub/mybinder.org-user-guide#213 got parsed as a link to some issue when I read the description, in fact it is another PR

@choldgraf
Copy link
Member Author

I just added back in Sphinx - I think at a location that does not trigger the bug @consideRatio mentioned? Is that right @consideRatio ?

Anything else to take care of here?

@consideRatio
Copy link
Member

@betatim this LGTM, merge agreement?

@sgibson91 sgibson91 self-requested a review October 19, 2020 08:09
Copy link
Member

@sgibson91 sgibson91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants