-
Notifications
You must be signed in to change notification settings - Fork 394
Remove federation related docs to split using and operating a bhub docs #1160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Erik Sundell <[email protected]>
Co-authored-by: Erik Sundell <[email protected]>
thanks - both applied! I also turned on readthedocs preview builds and if that works, will remove the circleci build (since it's just for docs preview) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the requirements.txt details that I wish no-one need to experience debugging more than me and I think @sgibson91 have already ended up doing, this LGTM! Thank you for your excellent work to make the documentation so great @choldgraf !
WDYT of the new title? I couldn't resist trying to find an alternative to the very generic one
|
I just added back in Sphinx - I think at a location that does not trigger the bug @consideRatio mentioned? Is that right @consideRatio ? Anything else to take care of here? |
@betatim this LGTM, merge agreement? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🎉
This is a general docs improvement that does a bit of restructuring and tidying. It also complements jupyterhub/mybinder.org-user-guide#213 as I moved over some content to these docs from there.
cc @consideRatio in case he wants to take a look at these too ;-)