Skip to content

Conversation

@Carreau
Copy link
Member

@Carreau Carreau commented Oct 19, 2025

  • run ruff check and ruff format
  • drop 3.8 (because we only test on 3.8+)
  • test on 3.14
  • apparently tempfile.NamedTemporaryFile is a function not a class for intersphinx

@Carreau Carreau requested a review from Copilot October 19, 2025 11:25
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR applies code formatting updates using ruff check and ruff format, updates the minimum Python version requirement from 3.5 to 3.8, adds testing for Python 3.14, and corrects documentation to reflect that tempfile.NamedTemporaryFile is a function rather than a class for intersphinx.

Key changes:

  • Applied consistent code formatting (double quotes, spacing) across all Python files
  • Updated minimum Python version from 3.5 to 3.8 in pyproject.toml
  • Added Python 3.14 and 3.14t to the test matrix

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/test_env.py Reformatted string quotes and spacing
tests/test_commands.py Reformatted string quotes, spacing, and replaced wildcard import with explicit imports
tests/test_asserts.py Reformatted string quotes, spacing, and replaced wildcard import with explicit imports
testpath/tempdir.py Fixed documentation reference from :class: to :func: for tempfile.NamedTemporaryFile and applied formatting
testpath/env.py Applied formatting with consistent spacing between functions
testpath/commands.py Reformatted string quotes, spacing, and formatting improvements
testpath/asserts.py Reformatted string quotes, spacing, and improved multi-line list formatting
testpath/init.py Replaced wildcard imports with explicit imports and applied formatting
pyproject.toml Updated minimum Python version from 3.5 to 3.8
doc/conf.py Reformatted string quotes and improved multi-line formatting
.github/workflows/test.yml Added Python 3.14 and 3.14t to test matrix

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Carreau Carreau changed the title MIsc Updates and bump tp 3.8+ MIsc Updates and bump to 3.8+ Oct 19, 2025
@Carreau Carreau changed the title MIsc Updates and bump to 3.8+ Misc Updates and bump to 3.8+ Oct 19, 2025
@Carreau Carreau merged commit 1740e42 into jupyter:main Oct 20, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant