Skip to content

Conversation

@jtpio
Copy link
Member

@jtpio jtpio commented Mar 18, 2022

This should help fix the failing CI on main.

This should also help with https://github.com/jupyterlab/retrolab/issues/358, since the new release include jupyterlab/jupyterlab#12218.

The new release includes the fix for ipython_genutils:

@jtpio jtpio added this to the 7.0 milestone Mar 18, 2022
@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch jtpio/notebook/update-lab

@jtpio
Copy link
Member Author

jtpio commented Mar 18, 2022

Looks like the cursor is now showing on some screenshots:

image

@jtpio
Copy link
Member Author

jtpio commented Mar 18, 2022

Tab completion also seems to be broken:

broken-tab-completion.mp4

@jtpio
Copy link
Member Author

jtpio commented Mar 18, 2022

Tab completion also seems to be broken:

That one seems to already be the case with notebook==7.0.0a1, so probably related to a previous change.

@jtpio jtpio marked this pull request as ready for review March 18, 2022 12:15
@jtpio
Copy link
Member Author

jtpio commented Mar 18, 2022

OK CI is all green now.

@jtpio
Copy link
Member Author

jtpio commented Mar 18, 2022

Merging since this fixes the CI, and brings a couple of other fixes we can ship in the next pre-release.

@jtpio jtpio merged commit c133317 into jupyter:main Mar 18, 2022
@jtpio jtpio deleted the update-lab branch March 18, 2022 15:10
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant