OutputWidget and Selection widget enhancements#3966
Open
fleming79 wants to merge 1 commit intojupyter-widgets:mainfrom
Open
OutputWidget and Selection widget enhancements#3966fleming79 wants to merge 1 commit intojupyter-widgets:mainfrom
fleming79 wants to merge 1 commit intojupyter-widgets:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Output
This change adds a new class to subclass the
SimplifiedOutputAreain place of theJupyterLuminoPanelWidgetfor the Output area.SimplifiedOutputAreawas deliberately chosen instead ofOutputArea.Before
Internally the layout is applied to a widget that contains the OutputArea meaning the layout doesn't apply to the OutputArea as expected. Here we unsuccessfully invert the widgets.
After
Now the layout applies as expected to the OutputArea. Here the widgets are inverted as directed.
Select
The
widget-selectcss class height is changed frominheritto100%enabling the selection field to span vertically by default.Before
After