Skip to content

Make determine_next_host an async function#122

Open
divyansshhh wants to merge 2 commits intojupyter-server:mainfrom
divyansshhh:async-determine-next-host
Open

Make determine_next_host an async function#122
divyansshhh wants to merge 2 commits intojupyter-server:mainfrom
divyansshhh:async-determine-next-host

Conversation

@divyansshhh
Copy link
Copy Markdown

@divyansshhh divyansshhh commented Nov 23, 2023

@welcome
Copy link
Copy Markdown

welcome bot commented Nov 23, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@divyansshhh divyansshhh mentioned this pull request Nov 23, 2023
Open
kevin-bates
kevin-bates approved these changes Nov 27, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you @divyansshhh!

@kevin-bates kevin-bates added the enhancement An improvement to an existing feature label Nov 27, 2023
@kevin-bates
Copy link
Copy Markdown
Member

kevin-bates commented Nov 27, 2023

@divyansshhh - any ideas why the yarn test is encountering the invalid argument issue? I see that this has been happening for some time now (sorry about that).

@divyansshhh
Copy link
Copy Markdown
Author

divyansshhh commented Dec 1, 2023

Taking a look.

kevin-bates
kevin-bates approved these changes May 24, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@divyansshhh - thanks again! I apologize for the lack of a response!

We can tackle the test failure another day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevin-bates kevin-bates kevin-bates approved these changes

Assignees

No one assigned

Labels

enhancement An improvement to an existing feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@divyansshhh @kevin-bates